Merged
Conversation
Member
There was a problem hiding this comment.
Suggested change
| buildInputs = [ groff libxml2 opensp libiconv iconv bash ] | |
| buildInputs = [ groff libxml2 opensp libiconv bash ] |
also we should set strictDeps
4677a38 to
e5f4ec6
Compare
Related: NixOS#328783 Ref: NixOS#178468
e5f4ec6 to
52cdd2a
Compare
Contributor
Author
|
@ofborg eval |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2143 |
|
|
||
| nativeBuildInputs = [ makeWrapper perlPackages.perl texinfo libxslt ]; | ||
| buildInputs = [ groff libxml2 opensp libiconv iconv bash ] | ||
| strictDpes = true; |
Contributor
There was a problem hiding this comment.
strictDeps = true;
There is a typo there!
Contributor
Author
There was a problem hiding this comment.
Ooops, sorry, and thank you for spotting this. Fix: #400315
Contributor
There was a problem hiding this comment.
this package doesn't work correctly under strictDeps, see #412735. the issue is that configure.ac does a few AC_PATH_PROG for sgml2xml, sx and osx and embeds these paths into the code (so really this should be AC_PATH_TOOL as these are host deps).
this breaks with strictDeps since buildInputs are no longer in PATH. I'm not good at autotools, do you if there's any agreed on way in nixpkgs to package things that make use of AC_PATH_TOOL and friends?
13 tasks
13 tasks
mildsunrise
added a commit
to mildsunrise/nixpkgs
that referenced
this pull request
Jun 12, 2025
Fixes NixOS#412735. NixOS#358347 / NixOS#400315 left the package broken because configure searces for osx in PATH and hardcodes its path on the Perl code. strictDeps logically prevents the dependency from being in PATH, so an empty string is hardcoded and `sgml2xml-isoent` doesn't work. The best fix that comes to mind is overriding the autoconf test result via the environment variable.
mildsunrise
added a commit
to mildsunrise/nixpkgs
that referenced
this pull request
Jun 12, 2025
Fixes NixOS#412735. NixOS#358347 / NixOS#400315 left the package broken because configure searces for osx in PATH and hardcodes its path on the Perl code. strictDeps logically prevents the dependency from being in PATH, so an empty string is hardcoded and `sgml2xml-isoent` doesn't work. The best fix that comes to mind is overriding the autoconf test result via the environment variable.
13 tasks
ttuegel
pushed a commit
to ttuegel/nixpkgs
that referenced
this pull request
Jun 16, 2025
Fixes NixOS#412735. NixOS#358347 / NixOS#400315 left the package broken because configure searces for osx in PATH and hardcodes its path on the Perl code. strictDeps logically prevents the dependency from being in PATH, so an empty string is hardcoded and `sgml2xml-isoent` doesn't work. The best fix that comes to mind is overriding the autoconf test result via the environment variable.
wolfgangwalther
pushed a commit
that referenced
this pull request
Jun 30, 2025
Fixes #412735. #358347 / #400315 left the package broken because configure searces for osx in PATH and hardcodes its path on the Perl code. strictDeps logically prevents the dependency from being in PATH, so an empty string is hardcoded and `sgml2xml-isoent` doesn't work. The best fix that comes to mind is overriding the autoconf test result via the environment variable. (cherry picked from commit d822ab9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #328783
Ref: #178468
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.