docbook2x: add runtime dependency on iconv binary#328783
Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom Jul 24, 2024
Merged
docbook2x: add runtime dependency on iconv binary#328783Ericson2314 merged 1 commit intoNixOS:stagingfrom
Ericson2314 merged 1 commit intoNixOS:stagingfrom
Conversation
This package uses iconv(1), which is provided by pkgs.iconv. This won't be a problem unless libiconv != iconv, e.g. on FreeBSD.
ofalvai
added a commit
to ofalvai/nixpkgs
that referenced
this pull request
Dec 7, 2024
Related: NixOS#328783 Ref: NixOS#178468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This package uses iconv(1), which is provided by pkgs.iconv. This won't be a problem unless libiconv != iconv, e.g. on FreeBSD.
Be explicit about this dep.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.