vala: remove unconditional work around for clang 16 function pointer errors#330015
Merged
fabianhjr merged 1 commit intoNixOS:stagingfrom Aug 2, 2024
Merged
Conversation
…errors Hook accumulates the flag over sereval executions as observed in: - NixOS#301592 - NixOS#252484 (comment) Since this has been committed, gcc started emitting a warning on `-Wno-incompatible-function-poniter-types` being an unrecognized flag and additionally upstream vala added its own meassure to reduce these new pointer errors to warnings in its generated sources. https://gitlab.gnome.org/GNOME/vala/-/commit/23ec71b1a5c4cead3d1bdac82e184d0a63fa7b79 Which is part of the current release branch (https://gitlab.gnome.org/GNOME/vala/-/commits/0.56?ref_type=heads) and released on 0.56.15 ``` Vala 0.56.15 ============ * Various improvements and bug fixes: - codegen: ... + Emit diagnostic pragmas for GCC 14, Clang 16 compatibility [NixOS#1408] ``` https://gitlab.gnome.org/GNOME/vala/-/merge_requests/369
12 tasks
13 tasks
Member
Author
|
@ofborg eval |
r-vdp
approved these changes
Jul 26, 2024
Contributor
r-vdp
left a comment
There was a problem hiding this comment.
I'm definitely not an expert on this, but if we indeed just don't need this flag anymore, then this PR will definitely solve the issue that I was having!
jtojnar
approved these changes
Jul 31, 2024
Member
jtojnar
left a comment
There was a problem hiding this comment.
Thanks, looks reasonable to me after checking the upstream commit. Did not verify if it actually fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Hook accumulates the flag over several executions as observed in:
-Wno-incompatible-function-pointer-typesis used 523 times in fwupd dev environment #301592Since this has been committed, gcc started emitting a warning on
-Wno-incompatible-function-poniter-typesbeing an unrecognized flag and additionally upstream vala added its own measure to reduce these new pointer errors to warnings in its generated sources.https://gitlab.gnome.org/GNOME/vala/-/commit/23ec71b1a5c4cead3d1bdac82e184d0a63fa7b79
Which is part of the current release
branch (https://gitlab.gnome.org/GNOME/vala/-/commits/0.56?ref_type=heads) and released on 0.56.15
https://gitlab.gnome.org/GNOME/vala/-/merge_requests/369
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Only tested gcc stdenv, would appreciate testing on clang stdenv platforms.
Add a 👍 reaction to pull requests you find important.