Skip to content

-Wno-incompatible-function-pointer-types is used 523 times in fwupd dev environment #301592

@tmuehlbacher

Description

@tmuehlbacher

Describe the bug

The dev environment for fwupd contains an inexplicably high number of the same compiler flags, causing an extreme amount of compiler warnings if using meson setup build && ninja -C build inside of it.

Steps To Reproduce

Steps to reproduce the behavior:

$ nix print-dev-env nixpkgs#fwupd | grep -o -- '-Wno-incompatible-function-pointer-types' | wc -l
523

To see flood of compiler messages:

$ nix-shell '<nixpkgs>' -A fwupd
$ eval "${unpackPhase:-unpackPhase}"
$ cd $sourceRoot
$ eval "${patchPhase:-patchPhase}"
$ meson setup --prefix $out $mesonFlags build
$ ninja -C build

Expected behavior

I think that $NIX_CFLAGS_COMPILE should not contain duplicate items. I have honestly no clue how this happens from looking at the fwupd package in nixpkgs.

Notify maintainers

@r-vdp

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.2, NixOS, 24.05 (Uakari), 24.05.20240403.7781caa`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/etc/nix/inputs/nixpkgs`

Add a 👍 reaction to issues you find important.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions