ncurses: install *.pc files (pkg-config)#1408
Merged
peti merged 2 commits intoNixOS:stdenv-updatesfrom Dec 26, 2013
Merged
Conversation
Contributor
Author
|
Linux From Scratch1 uses the same trick as nixpkgs to provide "normal" ncurses library symlinks files when ncurses is built in "wide" mode. And they provide symlink from normal to wide *.pc file too. I'll update the pull. |
To make e.g. "pkg-config --cflags ncursesw" work. The ncurses expression, when built in unicode/wide char mode, provides backward compatibility symlinks from lib<name>.so to lib<name>w.so. Provide similar symlinks for the *.pc files: <name>.pc -> <name>w.pc.
We already have backward compatibility symlinks for ncurses libraries and pkg-config files (when built in unicode/wide mode). The last bit is to add a symlink from ncurses5-config to ncursesw5-config, which is what this commit does.
peti
added a commit
that referenced
this pull request
Dec 26, 2013
ncurses: install *.pc files (pkg-config)
fabianhjr
added a commit
that referenced
this pull request
Aug 2, 2024
…errors Hook accumulates the flag over sereval executions as observed in: - #301592 - #252484 (comment) Since this has been committed, gcc started emitting a warning on `-Wno-incompatible-function-poniter-types` being an unrecognized flag and additionally upstream vala added its own meassure to reduce these new pointer errors to warnings in its generated sources. https://gitlab.gnome.org/GNOME/vala/-/commit/23ec71b1a5c4cead3d1bdac82e184d0a63fa7b79 Which is part of the current release branch (https://gitlab.gnome.org/GNOME/vala/-/commits/0.56?ref_type=heads) and released on 0.56.15 ``` Vala 0.56.15 ============ * Various improvements and bug fixes: - codegen: ... + Emit diagnostic pragmas for GCC 14, Clang 16 compatibility [#1408] ``` https://gitlab.gnome.org/GNOME/vala/-/merge_requests/369
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make e.g. "pkg-config --cflags ncursesw" work.
We also have ncurses v5.4 (old) in nixpkgs, but that version doesn't
know how to generate *.pc files. So I'm not touching it.
There is one thing I'd like to discuss before this is merged. In the ncurses expression there is this comment[1]:
When building a wide-character (Unicode) build, create backward
compatibility links from the the "normal" libraries to the
wide-character libraries (e.g. libncurses.so to libncursesw.so).
Should that also apply to the pkg-config files? With this patch pkg-config will know about "ncursesw", but should we also make it know about "ncurses" (minus the 'w')? (Of course, if ncurses is built without unicode/wide chars then it'll probably generate "ncurses" *.pc files and not "ncursesw".)
My initial thought is "no". I don't know why we want to make "backward compatibility links" in the first place. Is it completely safe?
[1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/ncurses/default.nix#L36-38