Skip to content

pkgs/development/libraries: remove unused fetchpatch and other arguments#313402

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:remove-fetchpatch-pkgs-development
May 23, 2024
Merged

pkgs/development/libraries: remove unused fetchpatch and other arguments#313402
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:remove-fetchpatch-pkgs-development

Conversation

@Sigmanificient
Copy link
Copy Markdown
Member

@Sigmanificient Sigmanificient commented May 21, 2024

Description of changes

This is a follow-up pr from the previous cleanup pr, since it did well:

I continued remove unused fetchpatch arguments, targeting the ones within pkgs/development/libraries.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label May 21, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 21, 2024
@Sigmanificient Sigmanificient added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 21, 2024
@SuperSandro2000 SuperSandro2000 changed the title pkgs/development/libraries: remove unused fetchpatch arguments pkgs/development/libraries: remove unused fetchpatch and other arguments May 23, 2024
@SuperSandro2000 SuperSandro2000 merged commit d20a86c into NixOS:master May 23, 2024
@Sigmanificient Sigmanificient deleted the remove-fetchpatch-pkgs-development branch May 23, 2024 11:49
Sobte pushed a commit to Sobte/nixpkgs that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants