pkgs/applications: remove uneeded fetchpatch arguments#313271
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom May 21, 2024
Merged
pkgs/applications: remove uneeded fetchpatch arguments#313271Aleksanaa merged 1 commit intoNixOS:masterfrom
Aleksanaa merged 1 commit intoNixOS:masterfrom
Conversation
39606f6 to
56069d4
Compare
56069d4 to
0058552
Compare
SuperSandro2000
approved these changes
May 21, 2024
RaghavSood
approved these changes
May 21, 2024
Aleksanaa
approved these changes
May 21, 2024
Member
Aleksanaa
left a comment
There was a problem hiding this comment.
Diff looks clean, and ofborg eval passes.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is a follow-up pr from the previous cleanup pr, since it did well:
This time I started remove unused
fetchpatcharguments.However, due to their higher count, I choose to split the pr into manageable parts, starting with
pkgs/applicationswith a total of70files affected.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.