Skip to content

treewide: remove unused occurence of fetchurl argument#313048

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
Sigmanificient:reemove-unused-fetchurl
May 20, 2024
Merged

treewide: remove unused occurence of fetchurl argument#313048
Aleksanaa merged 1 commit intoNixOS:masterfrom
Sigmanificient:reemove-unused-fetchurl

Conversation

@Sigmanificient
Copy link
Copy Markdown
Member

@Sigmanificient Sigmanificient commented May 20, 2024 •
edited
Loading

Description of changes

Remove unused occurrences of fetchurl that appeared throughout nixpkgs due to updates/refactoring.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels May 20, 2024
@Sigmanificient Sigmanificient force-pushed the reemove-unused-fetchurl branch from e99b862 to a235371 Compare May 20, 2024 03:20
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 20, 2024
@Sigmanificient Sigmanificient added the 8.has: clean-up This PR removes packages or removes other cruft label May 20, 2024
@RaghavSood
Copy link
Copy Markdown
Member

RaghavSood commented May 20, 2024

Result of nixpkgs-review pr 313048 run on x86_64-linux 1

2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

@Aleksanaa Aleksanaa merged commit 6944c9d into NixOS:master May 20, 2024
@Sigmanificient Sigmanificient deleted the reemove-unused-fetchurl branch May 20, 2024 07:08
@Sigmanificient Sigmanificient mentioned this pull request May 21, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @RaghavSood @Aleksanaa