tests.nixpkgs-check-by-name: Fix ratchet checks in certain cases#283017
Merged
infinisil merged 4 commits intoNixOS:masterfrom Jan 24, 2024
Merged
tests.nixpkgs-check-by-name: Fix ratchet checks in certain cases#283017infinisil merged 4 commits intoNixOS:masterfrom
infinisil merged 4 commits intoNixOS:masterfrom
Conversation
- Renames EmptyNonAutoCalled to ManualDefinition and add some docs to better explain what it's for - Don't conflate the Ratchet type with the Context type, keep them apart, making the code a bit cleaner, but also allows adding additional context for a Tight ratchet in the future - Change the signature of to_nixpkgs_problem to align with the other ratchet function signatures
Introduces NonApplicable as a state of a ratchet, to be used when the ratchet doesn't make sense to have. This fixes an odd problem where before, changing an attribute to use e.g. `callPackage` suddenly requires moving it to `pkgs/by-name`, when that shouldn't have been required.
Stops enforcing that packages whose evaluation gets fixed have to be moved to `pkgs/by-name`. This didn't really cause problems before, but I don't think it's great behavior, and now that NonApplicable is a thing, we can easily make this work, whereas before it would've been a larger change.
13 tasks
This was referenced Jan 25, 2024
infinisil
added a commit
that referenced
this pull request
Jan 29, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-53/39180/1 |
infinisil
added a commit
to NixOS/nixpkgs-vet
that referenced
this pull request
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes an odd problem where changing an attribute to use e.g.
callPackagesuddenly requires moving it topkgs/by-name, when that shouldn't have been required.See #282448 and the CI run: https://github.com/NixOS/nixpkgs/actions/runs/7618046790/job/20748392177
Ping @hzeller
This work is sponsored by Antithesis and Tweag ✨
Things done
Add a 👍 reaction to pull requests you find important.