sdrpp: 1.0.4 -> 1.1.0-unstable-2024-01-22#282448
Merged
kirillrdy merged 1 commit intoNixOS:masterfrom Jan 24, 2024
Merged
Conversation
Contributor
Author
|
Looks like the pkgs/by-name check did get confused because the line in |
bb829fd to
b99e41e
Compare
dc98857 to
ea66b97
Compare
sikmir
reviewed
Jan 22, 2024
sikmir
reviewed
Jan 22, 2024
Member
|
Result of 1 package built:
|
ea66b97 to
79c92ae
Compare
Member
|
Oh this is an interesting failure of the new Edit: CI fix in #283017 |
79c92ae to
4fd9fd8
Compare
sdrpp switched to a rolling release, so take a git hash from head.
4fd9fd8 to
205038b
Compare
2 tasks
Contributor
Author
|
Anyone on this PR with the power to Approve/merge ? |
Member
|
I can merge, @sikmir is this formally approved ? |
sikmir
reviewed
Jan 24, 2024
| sdrpp = callPackage ../applications/radio/sdrpp { | ||
| inherit (darwin.apple_sdk.frameworks) AppKit; | ||
| }); | ||
| }; |
Member
There was a problem hiding this comment.
Maybe move it here:
Suggested change
| }; | |
| rtl-sdr = rtl-sdr-osmocom; # osmocom better w/ rtlsdr v4 | |
| }; |
Contributor
Author
There was a problem hiding this comment.
I think moving that configuration there is probably better done in a separate change.
sikmir
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdrpp switched to a rolling release, so take a git hash from head.
rtl-sdr-osmocomwhich is a newer superset ofrtl-sdr(e.g. works better with rtl-sdr V4).Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.