Revert NetworkManager to 1.42.8#263985
Revert NetworkManager to 1.42.8#263985SuperSandro2000 wants to merge 2 commits intoNixOS:staging-nextfrom
Conversation
|
Was this reported upstream at all? I don't see anything linked in the debian report, and I can't find anything in the nm gitlab, and I've not been able to reproduce this issue on GNOME 45. Unfortunate timing, but i guess saves doing backports of 1.44 for the rest of 23.11 😅 |
|
Restarting Plasma (e.g. with |
K900
left a comment
There was a problem hiding this comment.
-1 on the revert, let me run it by the Plasma people first.
I couldn't find anything yet but I was also not sure what to search for exactly until now because I didn't have an error log.
That is a good observation! I'd also rather fix this but if we can't fix it until the end of November the current situation is not great. |
|
Filed upstream: https://bugs.kde.org/show_bug.cgi?id=476323 |
|
Duplicate of a 4-month old bug? Sounds like they can't solve it fast enough for us. |
|
I think the revert is the only acceptable choice for 23.11, but I don't love the idea of having to hold nm back after branch off in that situation. There's a comment on the issue mentioning Plasma 6 has this resolved - I don't follow KDE at all, so I'd appreciate if someone could weigh in as to what the timeline is for it landing in nix? The comments indicate that this is a Qt 6 fix, rather than anything in plasma-nm, and I'm not sure how Qt and plasma versions are related, if at all. |
|
Plasma 6 is pre-alpha, and requires Qt 6. What do you think about just not restarting NM on activation? That would be an easy workaround we can then always remove. |
|
At a superficial glance (these comments) I'd choose older NM for 23.11 and then perhaps immediately try newer one on unstable/master after fork-off. |
|
I cannot say I love the idea of potentially breaking the module as a workaround for this, and would much rather we ship 1.42.x for 23.11 - I'm not sure what all the consequences would be, but this seems like a lot to find out so close to release. The revert is safer. I assume going back to 1.44.x asap after branch off is going to be quite irritating for KDE users on Nix though, with there being 4 more months before Plasma 6 releases. I'm not sure what the right call is there, since it's not a bug in NM but in Plasma/Qt, but that's gonna matter more a month from now and not today. |
|
"Revert" or "leave broken" are not our only options. I am still looking into what's causing the bug on my end. |
|
Right, I'm not hitting merge here - branch off is not for another 2.5 weeks, but if it comes to it I would rather revert than remove restarting NM on activation. |
|
1.42 vs 1.44 is a difference better not left as late as branch-off date. There may be other packages where it matters, too. |
|
I think I have it. |
|
Please test: #264997 |
|
Update: final fix is in #265055 |
|
Reopening so this is not being forgotten and because the linked PR doesn't fully fix the problem and we are really to late to have such breaking changes for the stable branch off. |
Description of changes
NetworkManager 1.44.0 does not work with the current Plasma after a restart of the NetworkManager service. It can be sometimes worked around by unloading and loading the iwlwifi kernel module but things like wpa_supplicant continue to behave buggy.
Tested this on my plasma system and after this revert things worked again.
I am open for alternatives and testing things but I couldn't figure out a better way yesterday.
see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053707
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)