libsForQt5.networkmanager-qt: backport patch to fix NM 1.44 incompatibility#265055
Merged
vcunat merged 1 commit intoNixOS:masterfrom Nov 3, 2023
Merged
libsForQt5.networkmanager-qt: backport patch to fix NM 1.44 incompatibility#265055vcunat merged 1 commit intoNixOS:masterfrom
vcunat merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Member
|
I just tested this locally. I removed the revert to 1.42.8 on my fork and WiFis are now displayed after a NetworkManager restart but wifi passwords provieded via kwallet don't work and the applet reports back that no secrets where provided or that no agents were available for this request. So this PR only partially fixes the problem. |
65d6a76 to
35276ff
Compare
Contributor
Author
|
Try again. |
35276ff to
66be221
Compare
Contributor
Author
|
Tested everything I could here with different kwallet combinations and it seems fine. |
Member
|
I see no issue in merging these, even if it wasn't a complete fix. |
Member
|
With the second patch so far everything seems to work. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #263985 (hopefully).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)