Skip to content

Remove bqn mode#217317

Merged
AndersonTorres merged 4 commits intoNixOS:masterfrom
atorres1985-contrib:remove-bqn-mode
Mar 5, 2023
Merged

Remove bqn mode#217317
AndersonTorres merged 4 commits intoNixOS:masterfrom
atorres1985-contrib:remove-bqn-mode

Conversation

@AndersonTorres
Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres commented Feb 20, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Feb 20, 2023
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Feb 20, 2023
@ofborg ofborg bot requested a review from sternenseemann February 20, 2023 14:20
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 20, 2023
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Feb 20, 2023

Well, there is the problem the Emacs overlay is not updated to the latest MELPA (melpa/melpa@17711a1)...

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 22, 2023
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Mar 5, 2023

Now it is!

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 5, 2023
@ofborg ofborg bot removed the 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. label Mar 5, 2023
@AndersonTorres AndersonTorres merged commit aff3879 into NixOS:master Mar 5, 2023
@AndersonTorres AndersonTorres deleted the remove-bqn-mode branch March 5, 2023 13:22
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Mar 7, 2023 •
edited
Loading

Broke emacsPackages.ligo-mode.

source> unpacking source archive /build/archive.tar.gz?sha=d1073474efc9e0a020a4bcdf5e0c12a217265a3a
error: hash mismatch in fixed-output derivation '/nix/store/3kzk0rbsxjyx1y2dz8narp8bq88jr5n0-source.drv':
         specified: sha256-qlLBgKeabDi0UZNOll4PgXquterQN2zHxoY52AQ980Y=
            got:    sha256-wz9DF9mqi8WUt1Ebd+ueUTA314rKkdbjmoWF8cKuS8I=
error: 1 dependencies of derivation '/nix/store/npavsm83j6wpaqbmbqp95w43gxs39knx-emacs-ligo-mode-20230302.1616.drv' failed to build

This was referenced Mar 7, 2023
Closed
Closed
Closed
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Mar 9, 2023

I will revert this.

@AndersonTorres AndersonTorres mentioned this pull request Mar 9, 2023
Merged
12 tasks
AndersonTorres added a commit that referenced this pull request Mar 9, 2023
@AndersonTorres
Merge pull request #220322 from atorres1985-contrib/revert
b4dc5ae 
Revert "Merge pull request #217317 from atorres1985-contrib/remove-bq…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: emacs Text editor 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndersonTorres @mweinelt