Skip to content

Revert "Merge pull request #217317 from atorres1985-contrib/remove-bq…#220322

Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom
atorres1985-contrib:revert
Mar 9, 2023
Merged

Revert "Merge pull request #217317 from atorres1985-contrib/remove-bq…#220322
AndersonTorres merged 1 commit intoNixOS:masterfrom
atorres1985-contrib:revert

Conversation

@AndersonTorres
Copy link
Copy Markdown
Member

@AndersonTorres AndersonTorres commented Mar 9, 2023

…n-mode"

This reverts commit aff3879, reversing changes made to 573ed79.

According to the bug reported at
#217317 (comment), the Emacs package ligo-mode returns an unexpected hash.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@AndersonTorres
Revert "Merge pull request #217317 from atorres1985-contrib/remove-bq…
fe12fab 
…n-mode"

This reverts commit aff3879, reversing
changes made to 573ed79.

According to the bug reported at
#217317 (comment), the Emacs
package ligo-mode returns an unexpected hash.
@github-actions github-actions bot added the 6.topic: emacs Text editor label Mar 9, 2023
@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Mar 9, 2023

@ofborg build emacsPackages.ligo-mode

@AndersonTorres
Copy link
Copy Markdown
Member Author

AndersonTorres commented Mar 9, 2023 •
edited
Loading

@ofborg build emacsPackages.bqn-mode

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Mar 9, 2023
@ofborg ofborg bot requested a review from sternenseemann March 9, 2023 12:25
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 9, 2023
@AndersonTorres AndersonTorres merged commit b4dc5ae into NixOS:master Mar 9, 2023
@AndersonTorres AndersonTorres deleted the revert branch April 29, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: emacs Text editor 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndersonTorres