Skip to content

google-cloud-cpp: 0.14.0 -> 1.32.1#143693

Merged
mkg20001 merged 1 commit intoNixOS:masterfrom
cpcloud:bump-google-cloud-cpp
Nov 4, 2021
Merged

google-cloud-cpp: 0.14.0 -> 1.32.1#143693
mkg20001 merged 1 commit intoNixOS:masterfrom
cpcloud:bump-google-cloud-cpp

Conversation

@cpcloud
Copy link
Copy Markdown
Contributor

@cpcloud cpcloud commented Oct 29, 2021

Motivation for this change

Update google-cloud-cpp

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 29, 2021
@cpcloud cpcloud mentioned this pull request Oct 31, 2021
Merged
12 tasks
@cpcloud cpcloud marked this pull request as draft October 31, 2021 11:13
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Oct 31, 2021 •
edited
Loading

This PR depends on #143967 and #143839.

@cpcloud cpcloud force-pushed the bump-google-cloud-cpp branch from 772ec68 to 2c799a2 Compare October 31, 2021 11:28
SuperSandro2000
SuperSandro2000 reviewed Oct 31, 2021
View reviewed changes
@cpcloud cpcloud force-pushed the bump-google-cloud-cpp branch from 37e836c to fee847c Compare October 31, 2021 21:20
@cpcloud cpcloud force-pushed the bump-google-cloud-cpp branch from fee847c to dfa2798 Compare November 1, 2021 22:09
@cpcloud cpcloud marked this pull request as ready for review November 1, 2021 22:11
@cpcloud cpcloud force-pushed the bump-google-cloud-cpp branch 6 times, most recently from 1725941 to 3a6a8c6 Compare November 1, 2021 22:35
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 2, 2021

@SuperSandro2000 Any chance you can give this another review when you get a moment?

SuperSandro2000
SuperSandro2000 reviewed Nov 2, 2021
View reviewed changes
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Nov 2, 2021

other than the two minor things above this LGTM

@cpcloud cpcloud force-pushed the bump-google-cloud-cpp branch from 3a6a8c6 to 5b4c119 Compare November 2, 2021 10:18
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 2, 2021

@SuperSandro2000 Fixed, this should be good to go now. I have a follow up to this that will enable a large portion of the test suite for this package.

@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 3, 2021

@SuperSandro2000 Can this be merged?

@mkg20001
Copy link
Copy Markdown
Member

mkg20001 commented Nov 3, 2021

That's quite a lot of commits, that'll clobber history too much. You can actually just squash everything into one upgrade commit.

@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 3, 2021

@mkg20001 Right, sorry, meant to do that.

@cpcloud cpcloud force-pushed the bump-google-cloud-cpp branch from 5b4c119 to 33c991c Compare November 4, 2021 09:47
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 4, 2021

@SuperSandro2000 @mkg20001 Rebased and squashed.

@mkg20001 mkg20001 merged commit d2b31aa into NixOS:master Nov 4, 2021
@cpcloud cpcloud deleted the bump-google-cloud-cpp branch November 4, 2021 11:29
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 4, 2021

Thanks @mkg20001 !

SuperSandro2000
SuperSandro2000 reviewed Nov 4, 2021
View reviewed changes
pkgs/development/libraries/google-cloud-cpp/default.nix
url = "https://github.com/nlohmann/json/releases/download/v3.4.0/json.hpp";
sha256 = "0pw3jpi572irbp2dqclmyhgic6k9rxav5mpp9ygbp9xj48gnvnk3";
rev = googleapisRev;
hash = "sha256:1xrnh77vb8hxmf1ywqsifzd39kylhbdyah0b0b9bm7nw0mnahssl";
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This should use sha256 or an Sri hash, not a mixture of both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpcloud @SuperSandro2000 @mkg20001