abseil-cpp: remove cxx standard flag#143967
Merged
SuperSandro2000 merged 6 commits intoNixOS:masterfrom Nov 1, 2021
Merged
Conversation
12 tasks
Contributor
|
|
3ad0a2c to
d73c625
Compare
Member
|
This could use some commit squashing |
Contributor
Author
|
@veprbl Yup, I was waiting for approval. |
d73c625 to
f506ecd
Compare
Contributor
Author
|
@SuperSandro2000 @veprbl Squashed a couple commits. This is ready for another round of review. |
veprbl
approved these changes
Nov 1, 2021
Member
veprbl
left a comment
There was a problem hiding this comment.
Adding a whole new option is a bit of an overkill – an overrideAttrs would be enough, IMO, but this is a very reasonable change, nevertheless.
Member
|
Result of 23 packages marked as broken and skipped:
52 packages failed to build:
105 packages built:
|
Member
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 18 packages marked as broken and skipped:
9 packages failed to build and already failed to build on hydra master:
4 packages failed to build and are new build failures:
169 packages built:
|
Contributor
Author
|
@veprbl @SuperSandro2000 I'm not totally following what's breaking here. It looks like a few google-cloud packages are breaking, but they all seem to be broken on master too. How can I tell what's newly breaking in this PR vs master? |
Member
|
I am already taking care of this. My comment has more information. Most build failures are on darwin which is not a blocking problem. I am fixing telegram and fcitx5-mozc and all the google package which I am the maintainer for in another PR. |
Member
|
So, this can be merged when ofborg is done. |
Contributor
Author
|
@SuperSandro2000 Thanks for fixing! Much appreciated. |
Contributor
Author
|
@SuperSandro2000 I guess this is done? I'm assuming the darwin builds are hanging due to this #137678? |
Member
|
I don't know why more Darwin packages fail to be build exactly but there seems to be a lot of unrelated issues there which we are not going to investigate all in this pr. |
Contributor
Author
|
@SuperSandro2000 Thank you. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR removes
-DCMAKE_CXX_STANDARD=17from abseil-cpp while preserving the abilityto set it with
.override.Adding this flag to
abseil-cppforces all dependents to also set this flag to17,which isn't always possible.
or-toolsseems to be the only package that requires-DCMAKE_CXX_STANDARD=17, becauseit builds using
-std=c++17.I've got a package upgrade PR
that will not build with
-DCMAKE_CXX_STANDARD=17, and one more in progress that depends on #143693(both also depend on gRPC as well).
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)