Skip to content

crc32c: 1.1.0 -> 1.1.2#143839

Merged
SuperSandro2000 merged 7 commits intoNixOS:masterfrom
cpcloud:bump-crc32c
Nov 1, 2021
Merged

crc32c: 1.1.0 -> 1.1.2#143839
SuperSandro2000 merged 7 commits intoNixOS:masterfrom
cpcloud:bump-crc32c

Conversation

@cpcloud
Copy link
Copy Markdown
Contributor

@cpcloud cpcloud commented Oct 30, 2021

Motivation for this change
  • Update crc32c
  • Enable tests
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from andir October 30, 2021 12:26
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 30, 2021
@cpcloud cpcloud mentioned this pull request Oct 31, 2021
Merged
12 tasks
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 1, 2021

@andir Any chance you might be able to review this 😄 ?

andir
andir reviewed Nov 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first sight this doesn't look to bad of a change. Thanks for working on this!

In general no objections to the improvments.

Can you perhaps cleanup the Git history a bit? It currently has a bunch of commits that probably don't make sense on their own (e.g. enabling tests just to disable them again etc..).

@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 1, 2021

Can you perhaps cleanup the Git history a bit? It currently has a bunch of commits that probably don't make sense on their own (e.g. enabling tests just to disable them again etc..).

Yep, wanted to preserve since there were a few formatting changes in there and for review.

@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Nov 1, 2021

The tests should be fully enabled in the installCheckPhase, it's just that when tests are enabled the library builds and install gtest libraries which causes issues if dependents are using the nixpkgs version of gtest since the crc32c version would get picked up first in some cases.

@cpcloud cpcloud requested a review from andir November 1, 2021 13:08
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Nov 1, 2021

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 143839 run on x86_64-linux 1

28 packages built:
  • crc32c
  • dvc-with-remotes
  • google-cloud-cpp
  • python38Packages.gcsfs
  • python38Packages.gensim
  • python38Packages.google-cloud-automl
  • python38Packages.google-cloud-bigquery
  • python38Packages.google-cloud-storage
  • python38Packages.google-crc32c
  • python38Packages.google-resumable-media
  • python38Packages.pathy
  • python38Packages.smart-open
  • python38Packages.spacy
  • python38Packages.spacy-transformers
  • python38Packages.textacy
  • python39Packages.gcsfs
  • python39Packages.gensim
  • python39Packages.google-cloud-automl
  • python39Packages.google-cloud-bigquery
  • python39Packages.google-cloud-storage
  • python39Packages.google-crc32c
  • python39Packages.google-resumable-media
  • python39Packages.pathy
  • python39Packages.smart-open
  • python39Packages.spacy
  • python39Packages.spacy-transformers
  • python39Packages.textacy
  • snakemake

@SuperSandro2000 SuperSandro2000 merged commit 1fe2aba into NixOS:master Nov 1, 2021
@cpcloud cpcloud deleted the bump-crc32c branch November 1, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andir andir Awaiting requested review from andir

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpcloud @SuperSandro2000 @andir