Conversation
|
you need to change the follow the title format and commit format read https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md i made this issue so maybe we will get a release agda/cubical#583 |
There was a problem hiding this comment.
This should have the same effect:
preConfigure = ''makeFlagsArray=("AGDA_EXEC=agda -W error")'';
There was a problem hiding this comment.
This would need to be the other way round I think
There was a problem hiding this comment.
I have already fixed it.
|
We usually wait for a release before updating agda libraries but Its probably preferable to at least have something that works |
|
I changed the version to unstable. |
|
Discard the Use git rebase to fixup the commits into the first commit and reword the first commit |
I have already done the fixup. Look if everything is right. |
in the next dialog it would have been like this but this pr seems to be not needed now #131226 Thank you for the pr though! you should do your work in a separate branch instead of master |
b0a5ada to
46174ff
Compare
|
new pull request: |
Motivation for this change
Cubical Agda library was not working in Agda version 2.6.2. So I fixed it changing it to a newer version.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)