Skip to content

agdaPackages.cubical: 0.2 -> 0.3pred5030a9#131226

Merged
shlevy merged 1 commit intoNixOS:masterfrom
shlevy:agda-cubical-2.6.2
Jul 23, 2021
Merged

agdaPackages.cubical: 0.2 -> 0.3pred5030a9#131226
shlevy merged 1 commit intoNixOS:masterfrom
shlevy:agda-cubical-2.6.2

Conversation

@shlevy
Copy link
Copy Markdown
Member

@shlevy shlevy commented Jul 23, 2021

Motivation for this change

0.2 does not build with agda 2.6.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

0.2 does not build with agda 2.6.2
@github-actions github-actions bot added the 6.topic: agda A dependently typed programming language / interactive theorem prover label Jul 23, 2021
@ofborg ofborg bot requested a review from alexarice July 23, 2021 11:54
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 23, 2021
@shlevy
Copy link
Copy Markdown
Member Author

shlevy commented Jul 23, 2021

agdaPackages.cubical doesn't build on master and does on this branch, merging.

@shlevy shlevy merged commit f047001 into NixOS:master Jul 23, 2021
@shlevy shlevy deleted the agda-cubical-2.6.2 branch July 23, 2021 15:11
@Artturin Artturin mentioned this pull request Jul 23, 2021
11 tasks
Copy link
Copy Markdown
Contributor

@guilhermehas guilhermehas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this fix of PreConfig: #131280

sha256 = "18achbxap4ikydigmz3m3xjfn3i9dw4rn8yih82vrlc01j02nqpi";
};

LC_ALL = "en_US.UTF-8";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this line:

   preConfigure = ''export AGDA_EXEC=agda'';

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guilhermehas Why is this needed? It seems to build here...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it builds. But if you try to use the library, not everything is compiled.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guilhermehas I see, thanks, will fix

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like the fix is already in, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: agda A dependently typed programming language / interactive theorem prover 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants