Skip to content

Agda cubical 2.6.2 fix#131280

Merged
Mic92 merged 5 commits intoNixOS:masterfrom
guilhermehas:agda-cubical-2.6.2-fix
Jul 24, 2021
Merged

Agda cubical 2.6.2 fix#131280
Mic92 merged 5 commits intoNixOS:masterfrom
guilhermehas:agda-cubical-2.6.2-fix

Conversation

@guilhermehas
Copy link
Copy Markdown
Contributor

@guilhermehas guilhermehas commented Jul 23, 2021

Motivation for this change

Changing Agda Exec is necessary for the package to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: agda A dependently typed programming language / interactive theorem prover label Jul 23, 2021
@guilhermehas guilhermehas mentioned this pull request Jul 23, 2021
Closed
11 tasks
@ofborg ofborg bot requested a review from alexarice July 23, 2021 22:17
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 23, 2021
@Mic92 Mic92 merged commit cdac06c into NixOS:master Jul 24, 2021
@siraben
Copy link
Copy Markdown
Member

siraben commented Jul 24, 2021

This should have been rebased before merging.

@guilhermehas guilhermehas deleted the agda-cubical-2.6.2-fix branch July 24, 2021 13:22
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Jul 24, 2021 •
edited
Loading

This should have been rebased before merging.

I squashed it into one commit when merging. No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexarice alexarice Awaiting requested review from alexarice

Assignees

No one assigned

Labels

6.topic: agda A dependently typed programming language / interactive theorem prover 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guilhermehas @siraben @Mic92