Conversation
e2a9aed to
ba9cd57
Compare
This was referenced Jul 9, 2024
Closed
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-07-09/48759/1 |
9819e00 to
21eef6d
Compare
8 tasks
piegamesde
approved these changes
Jul 12, 2024
1 task
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Jul 18, 2024
Update it to https://hydra.nixos.org/eval/1807730#tabs-inputs, which notably contains some fixes for nixfmt: NixOS/nixfmt#215
infinisil
added a commit
to NixOS/nixpkgs
that referenced
this pull request
Jul 18, 2024
Update it to https://hydra.nixos.org/eval/1807730#tabs-inputs, which notably contains some fixes for nixfmt: NixOS/nixfmt#215 (cherry picked from commit 8e1b9b9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure that when testing formatting on all of Nixpkgs, the AST doesn't change, important for NixOS/nixpkgs#322520
This does make the Nixpkgs diff CI like 1 minute slower per commit, but this seems worth it.
Also discovered another bug from this, fix: #217