-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Reformat Nixpkgs #322520
Copy link
Copy link
Closed
Labels
6.topic: developer experiencenixpkgs development workflownixpkgs development workflow
Metadata
Metadata
Assignees
Labels
6.topic: developer experiencenixpkgs development workflownixpkgs development workflow
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Done
The recent python reformatting has shown that people are eager to have a uniform style already. Even though nixfmt isn't fully stable yet, we can already go ahead and use it to reformat all of Nixpkgs. With future nixfmt changes it can be reformatted again.
shell.nix/direnv integration: Development shell with a pinned nixfmt #322512Make sure
--verifysucceeds: Use --verify in Nixpkgs diff CI nixfmt#215Change the workflow to only enforce formatting of new/changed files, and do the first formatting pass
Fix [Tracking issue] remove all
src = ./.entries that unintentionally include their own.nixfiles #301014Wait until after the current release, minimise the number of conflicts (by picking a time with minimal open PRs)
[ ] Have better integrationMaketreefmt,nix fmtworkFix Remove recursive mode nixfmt#151 beforehand[ ] Have an easy maintainer script to rebase PRs with formatting: Script to rebase with formatting nixfmt#159Not a blocker
Open an issue/discourse post with information on the nixfmt reformatting
Format all actively developed branches (master, release-, staging-? (ask staging maintainers)) at the same time to avoid all backporting problems
[ ] Figure out how to do future reformats and nixfmt updates (pin it, probably separately from the main package)Not a blocker
[ ] Make sure there's no problems with generated filesCI will complain when they get updated without being formatted, which gives a good signal to the PR author that they need to either manually format, or implement the formatting in the generator