nix-shell: extend the meaning of $IN_NIX_SHELL#933
nix-shell: extend the meaning of $IN_NIX_SHELL#933vcunat wants to merge 1 commit intoNixOS:masterfrom
Conversation
... to allow detecting --pure
|
I tested the variable really is defined. Someone skilled in perl would better read the change... |
|
I'd like to bump this to make sure it doesn't get missed. It seems like a quick thing for the right person to review. I had to work around the The worst case was that the nixos-unstable install CD required setting EDIT: I suppose the latter case is somewhat unrelated and should be covered by NixOS/nixpkgs#15579. |
|
@edolstra: this PR is very simple. |
|
This breaks Nixpkgs, which has two checks for |
... to be compatible with NixOS/nix#933 while not breaking compatibility with current nix.
|
@edolstra: I fixed that up in nixpkgs master NixOS/nixpkgs@d4de02c46. It was trivial; unfortunately the notification for your answer was missed by me somehow. |
|
Note that |
|
Still, this PR would be a trivial merge for the meantime before we get perl-free. |
|
Pretty sure next Nix release will be perl free, all scripts have been ported ("just" need review): #341 |
|
C++ equivalent implemented: shlevy#2. I'm actually much more comfortable with C(++) than Perl. |
An equivalent was originally filed against the perl version: NixOS#933
|
My experience with nix repo is that "just review and merge" tends to take significantly more real time than actual implementation. |
|
@vcunat yes, that's because Eelco maintains software that a few thousand people use. It's also the reason I talked to Shea about the perl port, to get the bus factor down. We'll improve this, but it's a slow process. I'll help when I can :) |
|
Only this PR, and not the perl-to-C++ one, has the documentation update. |
... to be compatible with NixOS/nix#933 while not breaking compatibility with current nix. (cherry picked from commit d4de02c)
|
I just came across this accidentally. Any chance we can get this updated and merged? Seems like a cool feature. |
|
The feature is present in nix >= 2.0 via 1bffd83. |
... to be compatible with NixOS/nix#933 while not breaking compatibility with current nix. (cherry picked from commit d4de02c)
... to allow detecting --pure, e.g. in NixOS/nixpkgs#15571 (comment)