Conversation
dbf1b3b to
2c38cd7
Compare
This was a dumb line-for-line rewrite, because nix build/nix run/etc. will replace it.
An equivalent was originally filed against the perl version: NixOS#1018
An equivalent was originally filed against the perl version: NixOS#933
|
It seems some merge conflicts have originated in the meantime. |
|
Yep, I'll merge + fix conflicts once I get an OK from @edolstra |
| if (runEnv && argc > 1 && !std::regex_search(argv[1], std::regex("nix-shell"))) { | ||
| script = argv[1]; | ||
| if (access(script.c_str(), F_OK) == 0 && access(script.c_str(), X_OK) == 0) { | ||
| auto SCRIPT = std::ifstream(script); |
There was a problem hiding this comment.
No capitalized identifiers please.
There was a problem hiding this comment.
Also I would use tokenizeString(readFile(script), "\n") to read the file in lines.
|
@edolstra for many of your comments: I figured since |
|
Yeah that's true. Let's leave it this way for now, we can integrate it will "nix build" later. |
|
OK, which of these comments if any should I still address? |
|
All except the one about using |
|
@edolstra Pushed changes |
|
Thanks! Github is showing some merge conflicts though. |
|
Yep, will merge and resolve once it LGTY. |
|
Yes, looks good to me. |
|
🎆 |
We start this section with shortcomings of unsandboxed builds. Fixes NixOS#1018. Co-authored-by: eldritch horrors <pennae@lix.systems> Change-Id: Ieb17e4340beab0c1197951813ae602de453a3fd9 Signed-off-by: Raito Bezarius <raito@lix.systems>
This was a dumb line-for-line rewrite, because nix build/nix run/etc.
will replace it.