Reapply "meson: add soversion to libraries (#13960)"#13979
Closed
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Closed
Reapply "meson: add soversion to libraries (#13960)"#13979Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Conversation
This reverts commit 0db2b8c. This was original reverted to give the impression of an stable ABI. However version 0, from the looks of it this is in conventional Linux distribtion is not considered stable but a preparation to avoid conflict with future stable versions. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning I don't really see any downside on our side to add this and follow conventions here.
Member
Author
Contributor
|
Well maybe using the soversion same as the nix version would be more to your liking? |
Member
Author
I think 0 is better because we are not really doing abi versioning. |
juhp
added a commit
to juhp/nix
that referenced
this pull request
Sep 15, 2025
Contributor
|
I opened an alternative PR #13995 which makes the SONAME in sync with nix versions. |
juhp
added a commit
to juhp/nix
that referenced
this pull request
Sep 15, 2025
juhp
added a commit
to juhp/nix
that referenced
this pull request
Sep 15, 2025
…3960, NixOS#13979) remove 'pre' version suffix for non-releases (chokes Darwin ld)
juhp
added a commit
to juhp/nix
that referenced
this pull request
Sep 15, 2025
…3960, NixOS#13979) remove 'pre' version suffix for non-releases (chokes Darwin ld)
Member
Author
|
I prefer #13995 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0db2b8c.
This was original reverted to give the impression of an stable ABI.
However version 0, from the looks of it this is in conventional Linux distribtion is not considered stable but a preparation to avoid conflict with future stable versions.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning
I don't really see any downside on our side to add this and follow conventions here.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.