Skip to content

Commit 0db2b8c

Browse files
committed
Revert "meson: add soversion to libraries (#13960)"
This reverts commit bdbc739. Such a change needs more thought put into it. By versioning shared libraries we'd make a false impression that libraries themselves are actually versioned and have some sort of stable ABI, which is not the case. This will be useful when C bindings become stable, but as long as they are experimental it does not make sense to set SONAME. Also this change should not have been backported, since it's severely breaking.
1 parent 377b60e commit 0db2b8c

16 files changed

Lines changed: 0 additions & 16 deletions

File tree

src/libcmd/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ this_library = library(
9595
'nixcmd',
9696
sources,
9797
config_priv_h,
98-
soversion : 0,
9998
dependencies : deps_public + deps_private + deps_other,
10099
include_directories : include_dirs,
101100
link_args : linker_export_flags,

src/libexpr-c/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ subdir('nix-meson-build-support/windows-version')
5050
this_library = library(
5151
'nixexprc',
5252
sources,
53-
soversion : 0,
5453
dependencies : deps_public + deps_private + deps_other,
5554
include_directories : include_dirs,
5655
link_args : linker_export_flags,

src/libexpr-test-support/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ subdir('nix-meson-build-support/windows-version')
4444
this_library = library(
4545
'nix-expr-test-support',
4646
sources,
47-
soversion : 0,
4847
dependencies : deps_public + deps_private + deps_other,
4948
include_directories : include_dirs,
5049
# TODO: Remove `-lrapidcheck` when https://github.com/emil-e/rapidcheck/pull/326

src/libexpr/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ this_library = library(
181181
parser_tab,
182182
lexer_tab,
183183
generated_headers,
184-
soversion : 0,
185184
dependencies : deps_public + deps_private + deps_other,
186185
include_directories : include_dirs,
187186
link_args : linker_export_flags,

src/libfetchers-c/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ subdir('nix-meson-build-support/windows-version')
5353
this_library = library(
5454
'nixfetchersc',
5555
sources,
56-
soversion : 0,
5756
dependencies : deps_public + deps_private + deps_other,
5857
include_directories : include_dirs,
5958
link_args : linker_export_flags,

src/libfetchers/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ subdir('nix-meson-build-support/windows-version')
6161
this_library = library(
6262
'nixfetchers',
6363
sources,
64-
soversion : 0,
6564
dependencies : deps_public + deps_private + deps_other,
6665
include_directories : include_dirs,
6766
link_args : linker_export_flags,

src/libflake-c/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ subdir('nix-meson-build-support/windows-version')
5353
this_library = library(
5454
'nixflakec',
5555
sources,
56-
soversion : 0,
5756
dependencies : deps_public + deps_private + deps_other,
5857
include_directories : include_dirs,
5958
link_args : linker_export_flags,

src/libflake/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ this_library = library(
5858
'nixflake',
5959
sources,
6060
generated_headers,
61-
soversion : 0,
6261
dependencies : deps_public + deps_private + deps_other,
6362
include_directories : include_dirs,
6463
link_args : linker_export_flags,

src/libmain-c/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ subdir('nix-meson-build-support/windows-version')
4545
this_library = library(
4646
'nixmainc',
4747
sources,
48-
soversion : 0,
4948
dependencies : deps_public + deps_private + deps_other,
5049
include_directories : include_dirs,
5150
link_args : linker_export_flags,

src/libmain/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ this_library = library(
7777
'nixmain',
7878
sources,
7979
config_priv_h,
80-
soversion : 0,
8180
dependencies : deps_public + deps_private + deps_other,
8281
include_directories : include_dirs,
8382
link_args : linker_export_flags,

0 commit comments

Comments
 (0)