Improve derivation "advanced attrs" test, fix almost-bug#13032
Merged
Mic92 merged 2 commits intoNixOS:masterfrom Apr 15, 2025
Merged
Improve derivation "advanced attrs" test, fix almost-bug#13032Mic92 merged 2 commits intoNixOS:masterfrom
Mic92 merged 2 commits intoNixOS:masterfrom
Conversation
…alues We had fields set to the same values before in our test data. This is not a problem per-se, but does mean we wouldn't catch certain mixups. Now, the fields are set to distinct values (where possible), which makes the test more robust.
This was almost a bug! It wasn't simply because another assignment would clobber it later.
06c5f92 to
32409dd
Compare
mergify bot
added a commit
that referenced
this pull request
Apr 15, 2025
…3032 Improve derivation "advanced attrs" test, fix almost-bug (backport #13032)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See each commit for details. I changed the tests to perhaps catch the bug. That the tests didn't need to be updated again proved there was no bug, but it was close!
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.