Improve derivation "advanced attrs" test, fix almost-bug (backport #13032)#13033
Merged
mergify[bot] merged 2 commits into2.28-maintenancefrom Apr 15, 2025
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
…alues We had fields set to the same values before in our test data. This is not a problem per-se, but does mean we wouldn't catch certain mixups. Now, the fields are set to distinct values (where possible), which makes the test more robust. (cherry picked from commit a0b2b75)
This was almost a bug! It wasn't simply because another assignment would clobber it later. (cherry picked from commit 32409dd)
a0313ca to
29ae141
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See each commit for details. I changed the tests to perhaps catch the bug. That the tests didn't need to be updated again proved there was no bug, but it was close!
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #13032 done by [Mergify](https://mergify.com).