Add -Wundef and fix public headers#12931
Merged
Mic92 merged 3 commits intoNixOS:masterfrom Apr 5, 2025
Merged
Conversation
This commit has all the straightforward stuff.
Please fix this.
3803040 to
75c565e
Compare
75c565e to
ba89da8
Compare
Closed
roberth
commented
Apr 4, 2025
Member
Author
There was a problem hiding this comment.
This is the weird symlink that makes local development work. It gets copied into build and then points to the correct, generated file.
cole-h
approved these changes
Apr 5, 2025
Member
cole-h
left a comment
There was a problem hiding this comment.
Thanks, confirmed it fixes the test and trying to use an s3:// store on the CLI doesn't break!
mergify bot
added a commit
that referenced
this pull request
Apr 5, 2025
…2931 Add `-Wundef` and fix public headers (backport #12931)
Member
|
Curious about the second commit! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Context
I am not happy about the second commit, but it seems to work.
Surely there's a better way to use a public header in a meson subprojects setup??
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.