Skip to content

Fix S3 store#12930

Closed
edolstra wants to merge 1 commit intoNixOS:masterfrom
DeterminateSystems:fix-s3
Closed

Fix S3 store#12930
edolstra wants to merge 1 commit intoNixOS:masterfrom
DeterminateSystems:fix-s3

Conversation

@edolstra
Copy link
Copy Markdown
Member

@edolstra edolstra commented Apr 4, 2025

Motivation

Fixes #12928.

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@edolstra edolstra requested a review from Ericson2314 as a code owner April 4, 2025 22:28
@github-actions github-actions bot added the store Issues and pull requests concerning the Nix store label Apr 4, 2025
@edolstra edolstra added the backport 2.28-maintenance Automatically creates a PR against the branch label Apr 4, 2025
@edolstra edolstra marked this pull request as draft April 4, 2025 22:33
@edolstra edolstra marked this pull request as ready for review April 4, 2025 22:56
@roberth
Copy link
Copy Markdown
Member

roberth commented Apr 4, 2025

Also needs an include in filetransfer.cc - would probably only show at runtime...

https://github.com/NixOS/nix/pull/12931/files#diff-ac4189bb1b78aa9d7e8f334ca622f6dc25da6a3f128c1c9475aad6bf220a000dR11

#12931 should be complete thanks to -Werror=undef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.28-maintenance Automatically creates a PR against the branch store Issues and pull requests concerning the Nix store

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 stores and s3-binary-cache-store test are broken

2 participants