Shorten long lists of property values, with link to expand#969
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
=========================================
Coverage 58.79% 58.79%
Complexity 1505 1505
=========================================
Files 32 32
Lines 4208 4208
=========================================
Hits 2474 2474
Misses 1734 1734 Continue to review full report at Codecov.
|
joelit
approved these changes
Apr 9, 2020
Contributor
joelit
left a comment
There was a problem hiding this comment.
This looks good. I can foresee a request for hiding long lists again once they are revealed but that can be added later if someone really needs such.
Member
Author
|
Thanks @joelit ! Potential further work items before this is merged:
|
Merged
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way property values (e.g. skos:narrower or skos:related) are displayed when there are many of them. If there are more than 10 values (current hardcoded value), the list will be cut to the first 10 and a link
[show all X values]will be shown after those. Example:The message is translated - the PR includes Finnish, Swedish and English translations.
Fixes #833