Levelized label changes#770
Conversation
Also: * Remove parentheses from labels "LCOE Levelized cost of energy nominal" instead of "LCOE Levelized cost of energy (nominal)" because parentheses are used to indicate units. * Change WACC and LTE labels to follow convention of levelized variables.
Fix NPV and IRR labels
brtietz
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up! One minor comment about pre-tax vs after-tax IRR (in line), but I trust your judgement on the solution there.
| // metrics table | ||
| { SSC_OUTPUT, SSC_NUMBER, "project_return_aftertax_irr", "Internal rate of return (IRR, after-tax)", "%", "", "Metrics", "*", "", "" }, | ||
| { SSC_OUTPUT, SSC_NUMBER, "project_return_aftertax_npv", "Net present value (NPV, after-tax)", "$", "", "Metrics", "*", "", "" }, | ||
| { SSC_OUTPUT, SSC_NUMBER, "project_return_aftertax_irr", "IRR Internal rate of return", "%", "", "Metrics", "*", "", "" }, |
There was a problem hiding this comment.
It's a little odd to me to remove after-tax from this variable label, given that we also present pre-tax. Is it sufficiently obvious in the help that the "default" IRR presentation is after tax?
There was a problem hiding this comment.
@brtietz Thanks for noticing. I see that there is some inconsistency in these IRR and NPV labels throughout the financial cmods. For example, single owner has analysis_period_irr and flip_actual_irr in common.cpp and project_return_aftertax_irr in cmod_singleowner.cpp. There is also a distinction between the cash flow array variables like cf_project_return_aftertax_irr and metric number variables like project_return_aftertax_irr. I will clean those up.
* Levelized label changes (#770) * Revise labels of "levelized" variables Also: * Remove parentheses from labels "LCOE Levelized cost of energy nominal" instead of "LCOE Levelized cost of energy (nominal)" because parentheses are used to indicate units. * Change WACC and LTE labels to follow convention of levelized variables. * Fix cashloan LCOE labels Fix NPV and IRR labels * Fix DC degradation check should be lt instead of gt zero (#772) * Improve error messages for wfcheck (#773) * Improve error messages for wfcheck * fix mm-dd-hh * first test upload artifacts steps ssc * use upload artifacts path format, add ls checks for paths * fixes for PySAM (#775) * Add subcooled outlet option to DSG LF IPH model (#776) * add dsg lf subcooled outlet target add ui callback to calc saturation temp * update ssc cmake * add boolean and unique input for subcooled output * add cmake flag for shared dylib * remove path test steps Co-authored-by: Paul Gilman <cpaulgilman@gmail.com> Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov> Co-authored-by: Darice L Guittet <dguittet@nrel.gov>
Change variable labels for LCOE, NPV, and IRR to use consistent style like "LCOE Levelized cost of energy nominal:"
Fixes NatLabRockies/SAM#648
Goes with NatLabRockies/SAM#954