Conversation
run export_config, defaults, ssc tests and landbosse
|
Goes with SAM pull request 782 NatLabRockies/SAM#782 |
brtietz
left a comment
There was a problem hiding this comment.
When I try to run landbosse, it just spins forever. Pulling things up in the debugger it looks like too many escape characters have been added to the file path in the input JSON:
| input_dict_as_text | "{'weather_file_path':'C:\\Users\\bmirletz\\source\\repos\\sam_dev\\sam\\deploy\\wind_resource\\WY Southern-Flat Lands.srw','interconnect_voltage_kV':137.0,'distance_to_interconnect_mi':0.0,'depth':1.0... | const std::string &
Unrelated to the changes in this PR, is there a way to introduce more error checking into the for loop on line 285 of call_python_module_windows? It seems like either:
(1) There should be some maximum number of cycles that this should run before exiting to an error. AND/OR
(2) It should be checking std::err in addition to std::out to pick up on errors like this.
I'm fine to solve that in a patch, but this infinite loop makes for some fun debugging...
cpaulgilman
left a comment
There was a problem hiding this comment.
In my test of LandBosse from the UI, SAM crashes when I check Enable Land-Based Balance of System Cost Model on the Installation Costs page for a Wind / Single Owner case.
|
Update after some additional testing: if I install landbosse from develop and check the box, it works just fine. If I remove deploy/runtime/python-3.7.6 and attempt to re-install from this branch, SAM crashes. At least the behavior is consistent with Paul! |
|
Testing now...
…On Thu, Nov 18, 2021 at 12:49 PM Brian Mirletz ***@***.***> wrote:
Update after some additional testing: if I install landbosse from develop
and check the box, it works just fine. If I remove
deploy/runtime/python-3.7.6 and attempt to re-install, SAM crashes. At
least the behavior is consistent with Paul!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#664 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRSQB5JPGBU57OCNASJ27LUMVKFRANCNFSM5IJP27SA>
.
|
|
That is the exact behavior in 2020.11.29.r2... Isn't that what is expected
of anything Python related? ;-)
…On Thu, 18 Nov 2021 at 12:49, Brian Mirletz ***@***.***> wrote:
Update after some additional testing: if I install landbosse from develop
and check the box, it works just fine. If I remove
deploy/runtime/python-3.7.6 and attempt to re-install, SAM crashes. At
least the behavior is consistent with Paul!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#664 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRSQB5JPGBU57OCNASJ27LUMVKFRANCNFSM5IJP27SA>
.
|
|
Paul,
Are you building from develop or this pull request?
Both will crash along with 2020.11.29.r2 if you delete the
deploy/runtime/python-3.7.6 folder and then attempt to rerun landbosse...
…On Thu, 18 Nov 2021 at 10:28, Paul Gilman ***@***.***> wrote:
***@***.**** commented on this pull request.
In my test of LandBosse from the UI, SAM crashes when I check *Enable
Land-Based Balance of System Cost Model* on the Installation Costs page
for a Wind / Single Owner case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#664 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRSQBY54NNBXEYTLWSJZKLUMUZTRANCNFSM5IJP27SA>
.
|
|
I guess that will be a separate issue that I will fix in a separate pull
request.
…On Thu, 18 Nov 2021 at 12:49, Brian Mirletz ***@***.***> wrote:
Update after some additional testing: if I install landbosse from develop
and check the box, it works just fine. If I remove
deploy/runtime/python-3.7.6 and attempt to re-install, SAM crashes. At
least the behavior is consistent with Paul!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#664 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRSQB5JPGBU57OCNASJ27LUMVKFRANCNFSM5IJP27SA>
.
|
I built from the RapidJSON branch for both SAM and SSC. The runtime folder has a python folder with install_python.ps1, install_python.sh, landbosse.json, and python_config.json, which I guess are the files SAM uses to install python. There is no python-3.7.6 folder. (If I change the name of the folder from python to python-3.7.6 and start SAM I get a message box "Unhandled unknown exception; terminating the application.") |
|
LandBOSSE works for me now. Sorry that had to come up as part of this PR! ;) |
@cpaulgilman, that was great! Gave us a headstart on testing during lockdown! |
Addressed in commit fc3d2ec |
|
@sjanzou @cpaulgilman Great job adapting the LandBOSSE workflow's Python Installation from JSONCpp to RapidJSON! Looks like there were unexpected snags with writing and reading the JSON config files. And also re-installing Python after a manual deletion. Apologies, I should have documented how this Python installation works, and how to adapt it! Can do that after the release. Anything else that came up while you were struggling through this obtuse, undocumented workflow that I should add to the documentation? |





run export_config, defaults, ssc tests and landbosse