Skip to content

Replace JSONcpp with RapidJSON#782

Merged
sjanzou merged 5 commits into
developfrom
RapidJSON
Nov 19, 2021
Merged

Replace JSONcpp with RapidJSON#782
sjanzou merged 5 commits into
developfrom
RapidJSON

Conversation

@sjanzou

@sjanzou sjanzou commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator

run export_config, defaults, ssc tests and landbosse

@sjanzou
Replace JSONcpp with RapidJSON
e90f883 
run export_config, defaults, ssc tests and landbosse
@sjanzou

sjanzou commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator Author

Partially addresses issue #504 and #486

@sjanzou

sjanzou commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator Author

goes with ssc pull request 664 NatLabRockies/ssc#664

@sjanzou sjanzou mentioned this pull request Nov 18, 2021
Merged
cpaulgilman
cpaulgilman approved these changes Nov 18, 2021
View reviewed changes

@cpaulgilman cpaulgilman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested some of the SAM UI functions that use JSON, including URDB downloads, NSRDB, Cambium, marine wave resource, and all are working. These are still using wxWidgets JSON tools. Perhaps we should not change these until a later update.

@sjanzou

sjanzou commented Nov 18, 2021

Copy link
Copy Markdown
Collaborator Author

I tested some of the SAM UI functions that use JSON, including URDB downloads, NSRDB, Cambium, marine wave resource, and all are working. These are still using wxWidgets JSON tools. Perhaps we should not change these until a later update.

@cpaulgilman, that is correct... this pull request only replaces JSONcpp with RapidJSON and the SAM dependencies for this are in the landbosse and pythonhandler code used. We are now down to wxJSON and RapidJSON with this pull request and will eliminate wxJSON in another pull request.

@sjanzou sjanzou merged commit d7b8b69 into develop Nov 19, 2021
@sjanzou sjanzou deleted the RapidJSON branch November 19, 2021 05:12
@brtietz brtietz added this to the SAM Fall 2021 Release milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

@brtietz brtietz Awaiting requested review from brtietz

@dguittet dguittet Awaiting requested review from dguittet

@janinefreeman janinefreeman Awaiting requested review from janinefreeman

@mjprilliman mjprilliman Awaiting requested review from mjprilliman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

SAM Fall 2021 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@sjanzou @cpaulgilman @brtietz