Skip to content

Ensure weather data from new NSRDB endpoints downloaded in local time#950

Merged
cpaulgilman merged 1 commit into
patchfrom
nsrdb-full-disc-time-zone
Feb 23, 2022
Merged

Ensure weather data from new NSRDB endpoints downloaded in local time#950
cpaulgilman merged 1 commit into
patchfrom
nsrdb-full-disc-time-zone

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Description

Add attributes list for new NSRDB Full Disc endpoint: https://developer.nrel.gov/docs/solar/nsrdb/full-disc-download/.

Set default NSRDB parameter in URL request &utc=false so any new endpoints added in the future will hopefully be download in local time.

Note that this endpoint is not listed in the NSRDB API list at https://developer.nrel.gov/docs/solar/nsrdb/. I found it using a web search for "NSRDB API Full Disc."

Fixes #930

To test, build SAMnt_vs2019.sln in the SAM-private repository after building an open source version.

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • [x ] I have checked my code and corrected any misspellings

Set default NSRDB parameter utc=false so any new endpoints added in the future will hopefully be download in local time
@cpaulgilman cpaulgilman added this to the 2021.12.02 Patch 2 milestone Feb 21, 2022
@cpaulgilman cpaulgilman requested a review from brtietz February 21, 2022 23:28
@cpaulgilman cpaulgilman self-assigned this Feb 21, 2022

@brtietz brtietz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Good thought with the future-proofing "else" statement

@cpaulgilman cpaulgilman changed the title Ensure weather data from new NSRDB enpoints downloaded in local time Ensure weather data from new NSRDB endpoints downloaded in local time Feb 22, 2022
@cpaulgilman cpaulgilman merged commit b588f3d into patch Feb 23, 2022
@cpaulgilman cpaulgilman deleted the nsrdb-full-disc-time-zone branch February 23, 2022 22:59
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NSRDB timezone conversion is not selected by default for "Full disc" data sets

2 participants