Patch to develop 240718#1810
Conversation
Update lhs.bin and stepwise.bin to address #1417
Rerun defaults on Windows for failing GitHub Actions
Generate code...->LK for SDKtool code generation working for hybrids and non-hybrids configurations using generated JSON for inputs
Old version was misleading for one-axis trackers. Delete extra copies of image file.
Add json_file_to_ssc_data for code generation for SAM #1717
Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results. This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero. Checked that all other FOM spreadsheets do not have this problem.
Also trigger message on_change so message appears when you switch to Battery Dispatch pages.
* fix base branch * fix ref name * set default branch to patch
* Update defaults test results for new basis calculations. Expect increased lcoe due to decreased basis * Update single owner cash flow to excel for new basis calculations * Community solar send to excel for new basis calculations * Partnership flip spreadsheet for updated basis * Sale leaseback spreadsheet for basis updates * Update TPO Host Developer spreadsheet for new basis calcs * Merchant Plant spreadsheet for basis updates * Fix spreadsheet formatting for depr calcs * Help revisions for depreciation basis update * SAM_api and Windows test results updates for #1808 --------- Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov> Co-authored-by: Steven Janzou <steven@janzouconsulting.com>
Addresses SAM issue #1717
There was a problem hiding this comment.
equations.cpp appears correct based on issue 1634.
@brtietz , should we merge ssc PR 1184 first and then update the ci.yml to use the develop branches and update the test results on Windows using develop branch of ssc and this branch of SAM and commit and push and check GitHub Actions?
| @@ -220,7 +212,8 @@ bool EqnDatabase::PreProcessScript( wxString *text, wxArrayString* errors) | |||
| arg[1] = compute module name | |||
| arg[2] = sim_type value | |||
There was a problem hiding this comment.
Looks correct based on issue 1634.
#1813 resulted from attempting to do that. I'm open to merging this sooner (since develop will be less broken than it is with ssc merged) but also ok to hold off for a few days while I fix 1813. |
Uncertainty defaults
Update to minimum MacOS version 12 per SAM #1745
Complete transition from NMC to LFP
Pairs with NatLabRockies/ssc#1184 Tests may fail due to branch naming
For review: please confirm merge of equations.cpp went as intended.