UI Message for Battery Grid Charging with PBI#1792
Merged
Conversation
Also trigger message on_change so message appears when you switch to Battery Dispatch pages.
brtietz
approved these changes
Jun 14, 2024
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
The code looks good, thank you!
I'm not worried about the failing test on Mac, since this UI code wouldn't affect that model.
There's a minor consistency issue in the defaults: the default PBI term for front of meter is 10 years, whereas for BTM it's 0 years. That should be a separate issue if we choose to address it and can probably wait until the release.
Collaborator
Author
I think the default term should be zero if the default amount is zero to force the user to set both the PBI amount and term -- otherwise they may just set the PBI amount and not notice the term. |
dguittet
added a commit
that referenced
this pull request
Jun 25, 2024
* Update lhs.bin and stepwise.bin to address #1417 * Not sure why GitHub Actions failing when Mac binaries only thing updated * Fix base branch for GitHub Actions - patch * Rerun defaults on Windows for failing GitHub Actions * Fix indifference point macro description (#1788) * Update PV PDF report templates (#1789) * Fix Federal depreciation calculation in host_developer.xlsx (#1793) Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results. This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero. Checked that all other FOM spreadsheets do not have this problem. * UI message for battery grid charging with PBI (#1792) Also trigger message on_change so message appears when you switch to Battery Dispatch pages. * Marine Energy documentation revisions (#1790) * Fix base branch in Github CI (#1779) * fix base branch * fix ref name * set default branch to patch * update test results --------- Co-authored-by: sjanzou <sjanzou@gmail.com> Co-authored-by: Steven Janzou <steven@janzouconsulting.com> Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
dguittet
added a commit
that referenced
this pull request
Jun 25, 2024
* Update lhs.bin and stepwise.bin to address #1417 * Not sure why GitHub Actions failing when Mac binaries only thing updated * Fix base branch for GitHub Actions - patch * Rerun defaults on Windows for failing GitHub Actions * Fix indifference point macro description (#1788) * Update PV PDF report templates (#1789) * Update PV Tracking and Orientation diagram Old version was misleading for one-axis trackers. Delete extra copies of image file. * Update documentation for PV tracking and orientation * Revise PVWatts tilt and azimuth descriptions * Fix Federal depreciation calculation in host_developer.xlsx (#1793) Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results. This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero. Checked that all other FOM spreadsheets do not have this problem. * UI message for battery grid charging with PBI (#1792) Also trigger message on_change so message appears when you switch to Battery Dispatch pages. * Marine Energy documentation revisions (#1790) * Fix base branch in Github CI (#1779) * fix base branch * fix ref name * set default branch to patch * Address hybrid SAM lk scripting issues in #1636 * Squashed commit of the following: commit c5f39d5 Author: Paul Gilman <cpaulgilman@gmail.com> Date: Fri Jun 14 16:13:53 2024 -0700 Fix CEC Help topic commit d44d433 Author: Paul Gilman <cpaulgilman@gmail.com> Date: Fri Jun 14 16:00:05 2024 -0700 Help revisions for PV temperature, spectral, and optical models * Revise IEC 61853 topic to explain temperature, spectral, and optical models. * Add note for CEC model to explain air mass model. commit 05581df Author: Paul Gilman <cpaulgilman@gmail.com> Date: Fri Jun 14 15:58:13 2024 -0700 UI fixes for PV optical and spectral models * Display all available data for Sandia module model so users can see model coefficient values in UI without opening library CSV file. * Improve labeling of inputs for IEC 61853 module model * Improve Documentation of IEC 61858 temperature, optical, and spectral models (#1795) * UI fixes for PV optical and spectral models * Display all available data for Sandia module model so users can see model coefficient values in UI without opening library CSV file. * Improve labeling of inputs for IEC 61853 module model * Help revisions for PV temperature, spectral, and optical models * Revise IEC 61853 topic to explain temperature, spectral, and optical models. * Add note for CEC model to explain air mass model. * Fix CEC Help topic * Improve lk select_inputs() function description * revert test_results_win64.csv --------- Co-authored-by: sjanzou <sjanzou@gmail.com> Co-authored-by: Steven Janzou <steven@janzouconsulting.com> Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify existing UI callback function that displays message when grid charging is enabled with PTC to also display message with PBI.
Also trigger message on_change so message appears when you switch to Battery Dispatch pages.
Pull Request Template
Description
Fixes #1759
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.