Develop merge#1799
Merged
Merged
Conversation
Update lhs.bin and stepwise.bin to address #1417
Rerun defaults on Windows for failing GitHub Actions
Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results. This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero. Checked that all other FOM spreadsheets do not have this problem.
Also trigger message on_change so message appears when you switch to Battery Dispatch pages.
* fix base branch * fix ref name * set default branch to patch
sjanzou
approved these changes
Jun 21, 2024
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
The changes I have made look good. I am including @cpaulgilman as a reviewer since many of the file changes are documentation/help content.
brtietz
approved these changes
Jun 21, 2024
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for putting this together!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual merge using a develop-based feature branch in order to merge patch into develop while skipping over the change to ci.yml. This way the ci.yml in patch is different from the ci.yml in develop. Future merges of patch into develop are hypothesized to not include the ci.yml change.
updated test_results_win64.csv
#1779 and #1797