Skip to content

Depreciation and ITC Basis for Send-to-Excel with Equations#1808

Merged
cpaulgilman merged 10 commits into
patchfrom
1477_itc_incentive_interactions
Jul 17, 2024
Merged

Depreciation and ITC Basis for Send-to-Excel with Equations#1808
cpaulgilman merged 10 commits into
patchfrom
1477_itc_incentive_interactions

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Description

Update Excel workbooks for Send to Excel with Equations for FOM financial models to 1) report depreciation and ITC basis as separate variable and show how it is calculated, and 2) update Help to reflect those changes.

Fixes #1477
Goes with NatLabRockies/ssc#1178

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the 2023 Release Patch 2 milestone Jul 16, 2024
@cpaulgilman cpaulgilman requested review from brtietz and sjanzou July 16, 2024 23:30
@cpaulgilman cpaulgilman self-assigned this Jul 16, 2024
@cpaulgilman cpaulgilman changed the title 1477 itc incentive interactions Depreciation and ITC Basis for Send-to-Excel with Equations Jul 16, 2024

@sjanzou sjanzou left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spreadsheets look good.
Lots of help changes here - many non-financial - expected?
Also, SAM_api changes and Windows defaults updates committed to address failing GitHub Actions.

This seems like a good step for patch 2 and then the reserve account updates for the Fall release.

@cpaulgilman

Copy link
Copy Markdown
Collaborator Author

Lots of help changes here - many non-financial - expected?

Yes -- 9b654fd includes cumulative Help revisions to date. (This is a downside of our system of comitting the final generated HTML files instead of the source files for Help & Manual. We could store XML source files on GitHub, but Help & Manual is not open source software, which limits our options for integrating it into our build process.)

@brtietz

brtietz commented Jul 17, 2024

Copy link
Copy Markdown
Collaborator

@cpaulgilman The send to Excel looks good to me, but I'm not sure I agree with the current wording in the help. Specifically:

image

The highlighted line still describes the state before this PR. Net capital cost should be changed to "Total depreciation/ITC basis prior to allocation"

@cpaulgilman

Copy link
Copy Markdown
Collaborator Author

I'm not sure I agree with the current wording in the help.

Thank you for pointing that out. I corrected the descriptions of the IBI and CBI basis reduction for the Fall 2024 release: When Reduces Depreciation and ITC Basis is checked for an IBI or CBI, the depreciation and ITC bases are reduced by the full amount of the IBI or CBI.

For the ITC, checking Reduces Depreciation Basis reduces the depreciation basis by 50% of the ITC amount as per IRS rules.

@cpaulgilman cpaulgilman merged commit d1c7298 into patch Jul 17, 2024
@cpaulgilman cpaulgilman added added to release notes PR and/or issue has been added to release notes for a public release financial Financial model UI User interface issue that applies across performance and financial models labels Jul 24, 2024
@brtietz brtietz deleted the 1477_itc_incentive_interactions branch December 13, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release financial Financial model UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ITC and incentives interactions for host developer market only per test file

3 participants