Conversation
… linguist language calculations, and added samples folder to be ignored (#1669)
Remove nSCA as an input for CSP and IPH models. Add as design output.
* Clean up Save / Load buttons
* When loading data, add check that data appears to be valid based on variable name ('6par', 'cec_cg', etc in variable name).
* Make sure all variables to be exported have the correct group name property because `group_write()` and `group_read()` keys off of variable group name.
* Set group name for inverter temperature correction variables so temp data is included in exported/imported data file. This also ensures temp variable is listed with other inverter variables in LK editor, parametrics chooser, etc.
* Show file name in save/load message boxes to help with troubleshooting.
* Update `spe_data_filename` default to empty string, avoids <invalid>
* Make all save/load file name UI widgets calculated
* Update `spe_data_filename` default from "<invalid>" to "" empty string
Fix formatting of shading layout messages
Collaborator
Author
|
@cpaulgilman. you are included on this review due to potential relevance to #1464 |
cpaulgilman
approved these changes
Feb 19, 2024
cpaulgilman
left a comment
Collaborator
There was a problem hiding this comment.
Confirm that MSPT with test SSC branch crashes on SAM patch but runs successfully here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test, use ssc branch add-temp-mspt_cmod_var with this pull request - tests for REQUIRED_IF non-blank and UI_HINT == SMULATION_PARAMETER in the EqnDatabase::PreProcessScript function.
Create a MSPT/Single Owner case and run.
add-temp-mspt_cmod_var branch of ssc fails with patch branch of SAM and works with SAM_1634 branch of SAM:
