Skip to content

Clean up UI Save / Load buttons#1695

Merged
cpaulgilman merged 2 commits into
patchfrom
ui-save-load-buttons
Feb 13, 2024
Merged

Clean up UI Save / Load buttons#1695
cpaulgilman merged 2 commits into
patchfrom
ui-save-load-buttons

Conversation

@cpaulgilman

Copy link
Copy Markdown
Collaborator

Pull Request Template

Description

  • When loading data, add check that data appears to be valid based on variable name ('6par', 'cec_cg', etc in variable name).
    • Set group name for inverter temperature correction so temp data included in exported data file. This also ensures temp variable is listed with other inverter variables.
  • Make sure all variables to be exported have the correct group name
  • Show file name in save/load message boxes to help with troubleshooting.
  • Update spe_data_filename default to empty string, avoids
  • Make save/load file name UI widget calculated

Fixes #1687

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

* When loading data, add check that data appears to be valid based on variable name ('6par', 'cec_cg', etc in variable name).
* Make sure all variables to be exported have the correct group name property because `group_write()` and `group_read()` keys off of variable group name.
* Set group name for inverter temperature correction variables so temp data is included in exported/imported data file. This also ensures temp variable is listed with other inverter variables in LK editor, parametrics chooser, etc.
* Show file name in save/load message boxes to help with troubleshooting.
* Update `spe_data_filename` default to empty string, avoids <invalid>
* Make all save/load file name UI widgets calculated
@cpaulgilman cpaulgilman added the UI User interface issue that applies across performance and financial models label Feb 12, 2024
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 1 milestone Feb 12, 2024
@cpaulgilman cpaulgilman self-assigned this Feb 12, 2024
@cpaulgilman cpaulgilman merged commit 81116be into patch Feb 13, 2024
@cpaulgilman cpaulgilman deleted the ui-save-load-buttons branch February 13, 2024 22:07
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added to release notes PR and/or issue has been added to release notes for a public release UI User interface issue that applies across performance and financial models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PV CEC user specifciation Modules Save/Load Data buttons do not work

2 participants