Clean up UI Save / Load buttons#1695
Merged
Merged
Conversation
* When loading data, add check that data appears to be valid based on variable name ('6par', 'cec_cg', etc in variable name).
* Make sure all variables to be exported have the correct group name property because `group_write()` and `group_read()` keys off of variable group name.
* Set group name for inverter temperature correction variables so temp data is included in exported/imported data file. This also ensures temp variable is listed with other inverter variables in LK editor, parametrics chooser, etc.
* Show file name in save/load message boxes to help with troubleshooting.
* Update `spe_data_filename` default to empty string, avoids <invalid>
* Make all save/load file name UI widgets calculated
mjprilliman
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
spe_data_filenamedefault to empty string, avoidsFixes #1687
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.