Fix #1611 issue updating adjust in version upgrader#1614
Merged
Conversation
mjprilliman
reviewed
Nov 30, 2023
mjprilliman
left a comment
Collaborator
There was a problem hiding this comment.
Seems to fix the issue we were discussing yesterday. I am still having some trouble with the custom period updates but not sure if it is just me.
Steps:
- Create a Detailed PV - LCOE calculator in the 2022 release
- Save that file, close (don't change anything)
- Open that case in this branch
- Click Simulate
- adjust_periods is shown as [1] in inputs browser, upgrade notes.
janinefreeman
added a commit
that referenced
this pull request
Nov 30, 2023
* updated version upgrade script to change language in adjust variable notices and updated to correct list of technologies that require the upgrade * fixed logic for upgrading adjust:periods variable * updated upgrade script to clarify text for adjust variable changes * Add labels for adjust variables * updates to version upgrade script * updates to version upgrader * Fix #1611 issue updating adjust in version upgrader (#1614) * final fix to adjust_periods variable --------- Co-authored-by: Matt Prilliman <Matthew.Prilliman@nrel.gov> Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov> Co-authored-by: sjanzou <steven@janzouconsulting.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue was that version-upgrade-updates does not have the fix for issue 1608 merged into develop CaseWindow::UpdateConfiguration
– so that after upgrading, the inputs are overwritten with the defaults.
Update casewin.cpp with changes from develop and test – working and matching (2022.11.21 on left and updated on right - this branch)
with upgrade script
