Version upgrade updates#1602
Conversation
…notices and updated to correct list of technologies that require the upgrade
mjprilliman
left a comment
There was a problem hiding this comment.
Some labels missing for the upgrade reporting (and parametrics) + issues running the previous version defaults when no adjustment changes are made.
| value('adjust_en_timeindex', x.en_timeindex, 'Convert AC Losses adjust:en_timeindex to adjust_en_timeindex'); | ||
| value('adjust_timeindex', x.timeindex, 'Convert AC Losses adjust:timeindex to adjust_timeindex'); | ||
| message('Availability losses variable format changed from single table ("adjust") to separate variables: adjust_constant (number), adjust_en_timeindex (number), adjust_timeindex (array), adjust_en_periods (number), adjust_periods (array).'); | ||
| value('adjust_constant', x.constant); |
There was a problem hiding this comment.
dc_adjust and adjust variables need labels for PV Losses, potentially other technologies.
There was a problem hiding this comment.
This is likely a separate issue, as it looks like a lot of pages need names for adjust_" " variables.
| value('adjust_constant', x.constant); | ||
| value('adjust_en_periods', x.en_periods); | ||
| p = x.periods; //this logic works for both blank period arrays and for completed ones | ||
| value('adjust_periods', p); |
There was a problem hiding this comment.
adjust_periods_dc fails on simulate when upgrading the default detailed PV case (without changing anything)
There was a problem hiding this comment.
This issue also occurs for default Physical Trough CSP, likely others.
There was a problem hiding this comment.
I can't replicate this on my machine. However, what is getting loaded in seems to have changed and is no longer working for me. Possibly a wxwidgets issue? Let's talk more at our working session...
|
Will close #1604 |
|
version-upgrade-testing-csp.zip |
mjprilliman
left a comment
There was a problem hiding this comment.
The last commit fixed the issues I was finding on the first review. Thanks for working through this!
Updates the version upgrade script to make the language clearer for the adjust variable changes (from table with semicolons to separate variables with underscores) and fixes the logic for upgrading the "enable custom time period" losses in that widget, which were not upgrading correctly in the current dev version.
Please specifically test enabling a custom time period loss in SAM 2022.11.21 and upgrading that file, and check that the loss upgrades correctly.