fixes issue #1596 - update calculated value using overwrite_all_defaults.lk#1597
Merged
Conversation
brtietz
approved these changes
Nov 19, 2023
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Fantastic! Great to have the script working again.
The changes to startup.lk for NatLabRockies/ssc#1092 work as well. I had to make some additional changes to the defaults to make everything load properly (both hybrid_load and battery_load are required) and have pushed those here.
brtietz
pushed a commit
that referenced
this pull request
Nov 28, 2023
* initial PV capital cost updates * Update wind, battery, and hybrid default costs * finanical updates, most of 1471 * new bifacial shading default, fuel cell time series defaults * correct hybrid costs defaults typing * new ppa prices based on cost updates * run overwrite script on all configurations * update windows test results for new defaults * correct module prices for pv + battery * Fix calculated PV capacity for hybrid * Consistent `collapsible_var` defaults for all configurations * Fixes equation recalculations issue #1583 (#1587) * Correct defaults for pvwatts-wind-battery single owner * shift-f10 for PV, pv plus battery, and stand alone battery. Still getting some suspicious results from hybrids * updates to defaults, marine through generic * fixes issue #1596 - update calculated value using overwrite_all_defaults.lk (#1597) * Working on #1596 * Update fcall_overwrite to evaluate equations before saving. * Fix missing "load" for battery dispatch for hybrid host developer configurations * code cleanup * add battery_load default to compliment changes to startup.lk --------- Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov> * #1598 overwrite_defaults to update calculated values correctly for hybrids Update CaseEvent class to properly set ndxHybrid for CaseWindow::OnCaseEvent handling. * Update case event for correct vartable index * #1600 Remove debug file mslf_iph_mimo_ssc_auto_exec.lk created in deploy folder * Fix crashing defaults (MSLF/SO) issue #1600 * Windows defaults updates - slight changes in ETES and PTES --------- Co-authored-by: Paul Gilman <cpaulgilman@gmail.com> Co-authored-by: sjanzou <steven@janzouconsulting.com> Co-authored-by: Janine Keith <janinefreeman@users.noreply.github.com> Co-authored-by: sjanzou <sjanzou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should also fix NatLabRockies/ssc#1092