Cambium update to 2022#1365
Merged
Merged
Conversation
* Update URL in webapis.conf. * On UI form, read UUID from URL in webapis.conf instead of hard coding it. Future updates should only require updating the URL in webapis.conf. * Revise tooltip descriptions to be Cambium version agnositc. * Fix UI group box sizes so Merchant Plant Revenue page are all same size.
* Update sample script to Cambium 2020. * Update sample script to work for all PPA models, including Host Developer.
* Create macro based on sample script and add button to Revenue or Time of Delivery input page for all PPA models.
* Add optional escalation rate input and update defaults * Support non-monotonic available years from Cambium (Cambium 2020 years were even years, Cambium 2022 varies) * Update Help * Update UI descriptions and tooltips
sjanzou
reviewed
Mar 5, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Added SAM-private pull request 87 to go along with this pull request to update webapis.conf in SAM-private to prevent a hard crash.
Results with escalation seem a little weird in year 22 of the attached file with spreadsheet with corrected timestamps.... Maybe Cambium data has some weird values in 2045?
Collaborator
Author
|
@sjanzou Thanks -- I fixed a mistake in applying the escalation rate to years copied from previous available cambium years. Here is a detailed Excel spreadsheet that replicates copying previous years and escalation calculations. |
Collaborator
|
Unfortunately, even after Steve's fix, PVWatts-Merchant Plant still crashes for me when I click on the "revenue" tab (I have cambium-update-to-2022 checked out on SAM and sam-private). The debugger has an opaque compliant about a read access violation and an lk:error_t. |
Collaborator
Author
|
@brtietz SAM-private worked for me. I reran cmake and did a clean build to make sure all of the files were copied over from SAM. |
Collaborator
Ah, thanks. Doing a clean build fixed the crash. I'll do a deeper review tomorrow. |
sjanzou
approved these changes
Mar 7, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Cashflow looks much better - thanks for updating
Collaborator
|
Thanks, this is some great functionality! My one comment is it's not clear to me why the escalation rate would only be available for multi-year downloads for the merchant plant. Since single year data repeats for the lifetime, I would (and I imagine other users would as well) really like to be able to escalate single year data at the same rate as inflation. This would also more closely match the capabilities of the PPA models. Was there a reason that feature was disabled by default? |
Collaborator
Author
|
@brtietz Oh, right! I guess I got caught up in the excitement of the multi-year implementation. Escalation is enabled for both single-year and multi-year downloads and Help revised accordingly as of my last commits. |
brtietz
approved these changes
Mar 8, 2023
cpaulgilman
added a commit
that referenced
this pull request
Mar 17, 2023
* Cambium update to 2022 (#1365) * Update to Cambium 2022 * Update URL in webapis.conf. * On UI form, read UUID from URL in webapis.conf instead of hard coding it. Future updates should only require updating the URL in webapis.conf. * Revise tooltip descriptions to be Cambium version agnositc. * Fix UI group box sizes so Merchant Plant Revenue page are all same size. * Cambium sample script * Update sample script to Cambium 2020. * Update sample script to work for all PPA models, including Host Developer. * Cambium macro button for PPA models * Create macro based on sample script and add button to Revenue or Time of Delivery input page for all PPA models. * Help revisions for Cambium 2022 * UI adjustments for Mac/Linux * Update multiple year downloads for Cambium 2022 * Add optional escalation rate input and update defaults * Support non-monotonic available years from Cambium (Cambium 2020 years were even years, Cambium 2022 varies) * Update Help * Update UI descriptions and tooltips * Fix application of cambium escalation for copied data * Fix cambium progress bar text * Allow escalation for single-year download * Help updates for cambium single-year escalation * Fix input number format * WIND Toolkit downloads use wtk-download API endpoint (#1374) * Migrate from wtk-srw-download to wtk-download * Adds option to download subhourly wind resource data * Fix intervals list * Clean up WIND Toolkit download messages * Fix string declarations and typo
cpaulgilman
added a commit
that referenced
this pull request
Mar 23, 2023
* Cambium update to 2022 (#1365) * Update to Cambium 2022 * Update URL in webapis.conf. * On UI form, read UUID from URL in webapis.conf instead of hard coding it. Future updates should only require updating the URL in webapis.conf. * Revise tooltip descriptions to be Cambium version agnositc. * Fix UI group box sizes so Merchant Plant Revenue page are all same size. * Cambium sample script * Update sample script to Cambium 2020. * Update sample script to work for all PPA models, including Host Developer. * Cambium macro button for PPA models * Create macro based on sample script and add button to Revenue or Time of Delivery input page for all PPA models. * Help revisions for Cambium 2022 * UI adjustments for Mac/Linux * Update multiple year downloads for Cambium 2022 * Add optional escalation rate input and update defaults * Support non-monotonic available years from Cambium (Cambium 2020 years were even years, Cambium 2022 varies) * Update Help * Update UI descriptions and tooltips * Fix application of cambium escalation for copied data * Fix cambium progress bar text * Allow escalation for single-year download * Help updates for cambium single-year escalation * Fix input number format * WIND Toolkit downloads use wtk-download API endpoint (#1374) * Migrate from wtk-srw-download to wtk-download * Adds option to download subhourly wind resource data * Fix intervals list * Clean up WIND Toolkit download messages * Fix string declarations and typo * Move geocoding URLs to webapis.conf Update SAM CMakeLists.txt for new geotools.cpp New URLs in webapis.conf file for geocoding, static map, and time zone APIs. New URL in webapis.conf for calls to URDB wiki (for consistency, not related to geocoding) Move geocoding functions from WEX to new geotools.cpp file. Move LK `geocode()` from WEX to SAM so it can access SAM API keys. Define variables for Bing, Google, and special NREL Geocode API keys so that they can be managed in teh same way as SAM API key. Add new `user_email` variable so that open source versions of SAM can use NREL developer APIs that require an email parameter. Rename `GeoCodeDeveloper()` to `GeocodeDeveloper()`; Remove `SetApiKeys()` function, which is only required to make geocoding API keys available in WEX.
cpaulgilman
added a commit
that referenced
this pull request
Apr 14, 2023
* Cambium update to 2022 (#1365) * Update to Cambium 2022 * Update URL in webapis.conf. * On UI form, read UUID from URL in webapis.conf instead of hard coding it. Future updates should only require updating the URL in webapis.conf. * Revise tooltip descriptions to be Cambium version agnositc. * Fix UI group box sizes so Merchant Plant Revenue page are all same size. * Cambium sample script * Update sample script to Cambium 2020. * Update sample script to work for all PPA models, including Host Developer. * Cambium macro button for PPA models * Create macro based on sample script and add button to Revenue or Time of Delivery input page for all PPA models. * Help revisions for Cambium 2022 * UI adjustments for Mac/Linux * Update multiple year downloads for Cambium 2022 * Add optional escalation rate input and update defaults * Support non-monotonic available years from Cambium (Cambium 2020 years were even years, Cambium 2022 varies) * Update Help * Update UI descriptions and tooltips * Fix application of cambium escalation for copied data * Fix cambium progress bar text * Allow escalation for single-year download * Help updates for cambium single-year escalation * Fix input number format * WIND Toolkit downloads use wtk-download API endpoint (#1374) * Migrate from wtk-srw-download to wtk-download * Adds option to download subhourly wind resource data * Fix intervals list * Clean up WIND Toolkit download messages * Fix string declarations and typo * Move geocoding URLs to webapis.conf Update SAM CMakeLists.txt for new geotools.cpp New URLs in webapis.conf file for geocoding, static map, and time zone APIs. New URL in webapis.conf for calls to URDB wiki (for consistency, not related to geocoding) Move geocoding functions from WEX to new geotools.cpp file. Move LK `geocode()` from WEX to SAM so it can access SAM API keys. Define variables for Bing, Google, and special NREL Geocode API keys so that they can be managed in teh same way as SAM API key. Add new `user_email` variable so that open source versions of SAM can use NREL developer APIs that require an email parameter. Rename `GeoCodeDeveloper()` to `GeocodeDeveloper()`; Remove `SetApiKeys()` function, which is only required to make geocoding API keys available in WEX. * Replace remaning hard-coded urls with calls to SamApp::WebApi() * Update test results for NatLabRockies/ssc#1010
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixes #1104 and #1098
Updates Cambium downloads to Cambium 2022 and makes it easier to update in the future.
Add escalation rate for multiple year option, and support Cambium years in any interval (Cambium 2020 was even years, Cambium 2022 is even years 2024-2030 and then every five years 2030-2050).
Adds macro and button for PPA models to download cambium pricing data: See Revenue page for Single Owner model and Time of Delivery page for others.
Updates sample script for Cambium downloads.
Fixes Merchant plant layout for Mac and Linux.
Includes Help revisions.
To test in Merchant Plant:
To test in PPA models:
Type of change
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.