Move geocode#1387
Merged
Merged
Conversation
* Update to Cambium 2022 * Update URL in webapis.conf. * On UI form, read UUID from URL in webapis.conf instead of hard coding it. Future updates should only require updating the URL in webapis.conf. * Revise tooltip descriptions to be Cambium version agnositc. * Fix UI group box sizes so Merchant Plant Revenue page are all same size. * Cambium sample script * Update sample script to Cambium 2020. * Update sample script to work for all PPA models, including Host Developer. * Cambium macro button for PPA models * Create macro based on sample script and add button to Revenue or Time of Delivery input page for all PPA models. * Help revisions for Cambium 2022 * UI adjustments for Mac/Linux * Update multiple year downloads for Cambium 2022 * Add optional escalation rate input and update defaults * Support non-monotonic available years from Cambium (Cambium 2020 years were even years, Cambium 2022 varies) * Update Help * Update UI descriptions and tooltips * Fix application of cambium escalation for copied data * Fix cambium progress bar text * Allow escalation for single-year download * Help updates for cambium single-year escalation * Fix input number format
* Migrate from wtk-srw-download to wtk-download * Adds option to download subhourly wind resource data * Fix intervals list * Clean up WIND Toolkit download messages * Fix string declarations and typo
Update SAM CMakeLists.txt for new geotools.cpp New URLs in webapis.conf file for geocoding, static map, and time zone APIs. New URL in webapis.conf for calls to URDB wiki (for consistency, not related to geocoding) Move geocoding functions from WEX to new geotools.cpp file. Move LK `geocode()` from WEX to SAM so it can access SAM API keys. Define variables for Bing, Google, and special NREL Geocode API keys so that they can be managed in teh same way as SAM API key. Add new `user_email` variable so that open source versions of SAM can use NREL developer APIs that require an email parameter. Rename `GeoCodeDeveloper()` to `GeocodeDeveloper()`; Remove `SetApiKeys()` function, which is only required to make geocoding API keys available in WEX.
sjanzou
reviewed
Apr 14, 2023
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - any idea why the defaults changed?
Collaborator
Author
Defaults changed from adding time series power price escalation for Cambium updates -- I merged those changes into this branch to keep it up to date in 5300978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Move geocoding functions from WEX to SAM to allow all URLs from code to webapis.conf file.
Add
user_emailto SAM/private.h so NREL Developer API calls to NSRDB and others that require an email address will work.Motivation:
If web service URL changes, we can update the URL in webapis.conf without touching source code.
Centralized list of URLS provides transparency for users with cybersecurity questions about what web services SAM uses.
Fixes #1204
Goes with https://github.com/NREL/SAM-private/pull/90
Tests
NSRDB download with street address (Advanced Download option on Location and Resource page)
WIND toolkit download with street address
Marine Wave resource download (Wave Resource Data Download window does not have a location option, so GeocodeDeveloper() never gets called from UI)
3D shade calculator map underlay and map lookup by location name: On the Location tab, type an address and click Lookup address.
LK
geocode()function (Location without advanced option on Location and Resource page also tests this). For exampleoutln( geocode('National Renewable Energy Laboratory, Golden CO'));should print "{ lat=39.7444 lon=-105.152 tz=-7 ok=1 }".Note
geocode()not available from SDKtool LK script editor.Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.