fix(bundler): re-enable aws-ebs-csi-driver by default and support --set disable#397
Merged
mchmarny merged 4 commits intoNVIDIA:mainfrom Mar 13, 2026
Merged
Conversation
…et disable PR NVIDIA#382 disabled aws-ebs-csi-driver by default in EKS recipes assuming it was pre-installed as an EKS addon. However, EKS does not include it by default — only coredns, kube-proxy, and vpc-cni are included. This caused Prometheus PVC provisioning to fail on clusters without the addon. Changes: - Re-enable aws-ebs-csi-driver in the EKS overlay (remove overrides.enabled: false) - Add getSetEnabledOverride() so --set awsebscsidriver:enabled=false works at bundle time for clusters that have it as an EKS addon - --set overrides take precedence over recipe-level overrides Refs: NVIDIA#382 Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
7574a3e to
f2e3df8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mchmarny
requested changes
Mar 13, 2026
Member
mchmarny
left a comment
There was a problem hiding this comment.
Other than the Helm value leaking, LGTM
Contributor
|
This is blocking me, so I am going to push a fix to cover the review feedback so this can merge. |
Address review feedback on PR NVIDIA#397: - Strip "enabled" key from --set overrides before passing to Helm chart values to prevent unintended side effects in charts - Add test verifying enabled key does not leak into generated values.yaml - Add default happy path test case (recipe enabled + no --set => included) - Document enabled override in --set CLI help tex
mchmarny
previously approved these changes
Mar 13, 2026
Address review feedback on PR NVIDIA#397: - Strip "enabled" key from --set overrides before passing to Helm chart values to prevent unintended side effects in charts - Add test verifying enabled key does not leak into generated values.yaml - Add default happy path test case (recipe enabled + no --set => included) - Document enabled override in --set CLI help tex
mchmarny
approved these changes
Mar 13, 2026
xdu31
pushed a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
…et disable (NVIDIA#397) Signed-off-by: Yuan Chen <yuanchen97@gmail.com> Co-authored-by: Brian Lockwood <lockwobr@gmail.com> Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enable
aws-ebs-csi-driverby default in EKS recipes and add--setoverride support for disabling components at bundle time.Motivation / Context
PR #382 disabled
aws-ebs-csi-driverby default assuming EKS clusters have it as a managed addon. However, EKS only includescoredns,kube-proxy, andvpc-cniby default — EBS CSI must be explicitly installed. This caused Prometheus PVC provisioning to fail on EKS clusters without the addon.Related: #382
Type of Change
Component(s) Affected
pkg/recipe)pkg/bundler,pkg/component/*)Implementation Notes
overrides: enabled: falsefromaws-ebs-csi-driverinrecipes/overlays/eks.yamlgetSetEnabledOverride()inpkg/bundler/bundler.go— checks--setoverrides forenabledkey before the recipe-levelIsEnabled()check.--settakes precedence.Users can disable at bundle time:
--set awsebscsidriver:enabled=falseTesting
Verified on EKS (aicr-cuj1, p5.48xlarge):
--set awsebscsidriver:enabled=false: component skippedundeploy.shonly manages components it deployedRisk Assessment
Checklist
make testwith-race)make lint)git commit -S)