fix(bundler): skip components with overrides.enabled: false#382
Merged
mchmarny merged 2 commits intoNVIDIA:mainfrom Mar 12, 2026
Merged
fix(bundler): skip components with overrides.enabled: false#382mchmarny merged 2 commits intoNVIDIA:mainfrom
mchmarny merged 2 commits intoNVIDIA:mainfrom
Conversation
7b3e2c8 to
64cba2a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
b79f47f to
2374594
Compare
mchmarny
approved these changes
Mar 12, 2026
yuanchen8911
added a commit
to yuanchen8911/aicr
that referenced
this pull request
Mar 13, 2026
…et disable PR NVIDIA#382 disabled aws-ebs-csi-driver by default in EKS recipes assuming it was pre-installed as an EKS addon. However, EKS does not include it by default — only coredns, kube-proxy, and vpc-cni are included. This caused Prometheus PVC provisioning to fail on clusters without the addon. Changes: - Re-enable aws-ebs-csi-driver in the EKS overlay (remove overrides.enabled: false) - Add getSetEnabledOverride() so --set awsebscsidriver:enabled=false works at bundle time for clusters that have it as an EKS addon - --set overrides take precedence over recipe-level overrides Refs: NVIDIA#382 Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
9 tasks
yuanchen8911
added a commit
to yuanchen8911/aicr
that referenced
this pull request
Mar 13, 2026
…et disable PR NVIDIA#382 disabled aws-ebs-csi-driver by default in EKS recipes assuming it was pre-installed as an EKS addon. However, EKS does not include it by default — only coredns, kube-proxy, and vpc-cni are included. This caused Prometheus PVC provisioning to fail on clusters without the addon. Changes: - Re-enable aws-ebs-csi-driver in the EKS overlay (remove overrides.enabled: false) - Add getSetEnabledOverride() so --set awsebscsidriver:enabled=false works at bundle time for clusters that have it as an EKS addon - --set overrides take precedence over recipe-level overrides Refs: NVIDIA#382 Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
xdu31
added a commit
to xdu31/aicr
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
overrides.enabled: falsein the recipe (e.g.,aws-ebs-csi-driverin EKS overlay) were still included indeploy.sh, causing hangs during deploymentComponentRef.IsEnabled()method and filter disabled components early inbundler.Make()so neither Helm nor ArgoCD deployers generate output for themTest plan
go test -race ./pkg/recipe/... -run TestComponentRefIsEnabledgo test -race ./pkg/bundler/... -run TestMake_DisabledComponentsFilteredgo run ./cmd/aicr bundle --recipe <eks-recipe> --output bundle— verify disabled component has no directory and no deploy.sh entry