Skip to content

ci: revert bad uv.lock bump and label future bumps with Run functional tests#4730

Merged
ko3n1g merged 2 commits into
NVIDIA:mainfrom
ko3n1g:ko3n1g/ci/dependabot-functional-tests
May 11, 2026
Merged

ci: revert bad uv.lock bump and label future bumps with Run functional tests#4730
ko3n1g merged 2 commits into
NVIDIA:mainfrom
ko3n1g:ko3n1g/ci/dependabot-functional-tests

Conversation

@ko3n1g

@ko3n1g ko3n1g commented May 11, 2026

Copy link
Copy Markdown
Contributor
Claude summary

What

  1. Revert e93755e13a (chore(beep boop 🤖): Bump (main) (2026-05-11)) — the latest automated uv.lock bump on main. The bump landed a 785-/+894-line lockfile rewrite that needs to be re-cooked through CI with the functional suite.
  2. Workflow fix in .github/workflows/_update_dependencies.yml: attach the Run functional tests label to every bump PR opened by peter-evans/create-pull-request, so the functional suite (100 steps + golden-value compare) runs instead of the slim default.

Why

A bare uv.lock bump only triggers mr-github-slim scope, which can mask numerical regressions in pinned deps. Per cicd skill, lockfile bumps warrant Run functional tests.

# .github/workflows/_update_dependencies.yml
- name: Create Bump PR
  uses: peter-evans/create-pull-request@v8
  with:
    ...
    labels: Run functional tests

ko3n1g added 2 commits May 11, 2026 16:55
This reverts commit e93755e.

Signed-off-by: oliver könig <okoenig@nvidia.com>
uv.lock bumps can shift training numerics, so let CI run the full
functional suite (100 steps + golden-value compare) rather than the
slim default scope.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 11, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g

ko3n1g commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 354c78f

@ko3n1g ko3n1g marked this pull request as ready for review May 11, 2026 16:56
@ko3n1g ko3n1g requested a review from a team as a code owner May 11, 2026 16:56
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team May 11, 2026 16:57
@ko3n1g ko3n1g merged commit 5123f6a into NVIDIA:main May 11, 2026
25 of 27 checks passed
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label May 11, 2026
svcnvidia-nemo-ci added a commit that referenced this pull request May 12, 2026
Merges 8 commits from main into dev. Dev already contains yesterday's
sync (PR #4716) plus follow-up fixes, so this PR only carries main
commits made after that sync.

Notable changes:
- 434368c build(deps): bump nvidia-modelopt to 0.43 (#4723)
- e42e2fa ci: Major refactor of release-workflows (#4602)
- 33d47e0 [ci] fix: treat cancelled run-main-script step as failure (#4727)
- 5123f6a ci: revert bad uv.lock bump and label future bumps with
  Run functional tests (#4730)
- ad58411 Add Python-side guardrail for DeepEP IB limits (#4719)
- e93755e chore(beep boop): Bump (main) (2026-05-11)
- a2ec5c1 Revert Add Python-side guardrail for HybridEP IB limit (#4718)
- 5e31514 Create a Protocol for the MLP layer of TransformerLayer (#3435)

Kept dev's pyproject.toml, uv.lock, docker/Dockerfile.ci.dev, and
.github/CODEOWNERS (per nightly-sync skill).

Ran black + isort on changed Python files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: high

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants