build(deps): bump nvidia-modelopt to 0.43#4723
Merged
Merged
Conversation
nvidia-modelopt 0.43 requires setuptools>=80; relax the project-wide setuptools<80 cap across pyproject.toml, the fsdp subpackage, the CI Dockerfile, install scripts, and the wheel build workflow. Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
…-0.43 Signed-off-by: oliver könig <okoenig@nvidia.com> # Conflicts: # uv.lock
Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test 2c95b89 |
svcnvidia-nemo-ci
added a commit
that referenced
this pull request
May 12, 2026
Merges 8 commits from main into dev. Dev already contains yesterday's sync (PR #4716) plus follow-up fixes, so this PR only carries main commits made after that sync. Notable changes: - 434368c build(deps): bump nvidia-modelopt to 0.43 (#4723) - e42e2fa ci: Major refactor of release-workflows (#4602) - 33d47e0 [ci] fix: treat cancelled run-main-script step as failure (#4727) - 5123f6a ci: revert bad uv.lock bump and label future bumps with Run functional tests (#4730) - ad58411 Add Python-side guardrail for DeepEP IB limits (#4719) - e93755e chore(beep boop): Bump (main) (2026-05-11) - a2ec5c1 Revert Add Python-side guardrail for HybridEP IB limit (#4718) - 5e31514 Create a Protocol for the MLP layer of TransformerLayer (#3435) Kept dev's pyproject.toml, uv.lock, docker/Dockerfile.ci.dev, and .github/CODEOWNERS (per nightly-sync skill). Ran black + isort on changed Python files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude summary
What
Bump
nvidia-modeloptfrom0.42.0to0.43.0inuv.lock.Why
nvidia-modelopt==0.43.0requiressetuptools>=80, but the project had a hard capsetuptools<80.0.0(introduced in the initialpyproject.tomlcommit with no documented rationale). Without relaxing the cap, the resolver back-pedals to0.42.0.Changes
setuptools<80.0.0(andsetuptools<80.0.0,>=77.0.0) →setuptools>=80across every file in the repo that pinned it:pyproject.toml(build-system)setuptools>=80pyproject.toml(buildgroup)setuptools>=80pyproject.toml(devgroup)nvidia-modelopt[torch]>=0.43megatron/core/distributed/fsdp/src/pyproject.tomlsetuptools>=80docker/Dockerfile.ci.dev(project venv)setuptools>=80docker/common/install.shsetuptools>=80docker/common/install_source_wheels.shsetuptools>=80.github/workflows/_build_test_publish_wheel.ymlsetuptools>=80docker/Dockerfile.ci.devline 92 (setuptools<82.0.0in the isolated/opt/jetvenv forjet-api) is intentionally untouched — it's a separate venv and ajet-apicompatibility constraint, not the project venv.Resolver result
Note
nvidia-modeloptno longer exposes a[torch]extra (already absent in 0.42.0); the marker has been a silent no-op for at least a release. Left intact here to keep the diff focused on the version bump — worth dropping in a follow-up.